Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map pattern: Fixed an issue where the entire comparison value was not given for the DT. #25938

Merged
merged 16 commits into from Apr 20, 2023

Conversation

spearmin10
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

It didn't work well when giving an array or dictionary to the comparison of dt algorithm. This is a fix for it.

Screenshots

N/A

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@spearmin10 spearmin10 requested a review from ilaner as a code owner April 18, 2023 06:49
@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Apr 18, 2023
@content-bot content-bot changed the base branch from master to contrib/spearmin10_MapPattern April 18, 2023 06:50
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Apr 18, 2023
@dantavori dantavori assigned dantavori and unassigned merit-maita Apr 18, 2023
@dantavori dantavori requested review from dantavori and removed request for merit-maita and ilaner April 18, 2023 14:36
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@dantavori dantavori merged commit 0156890 into demisto:contrib/spearmin10_MapPattern Apr 20, 2023
15 of 18 checks passed
dantavori added a commit that referenced this pull request Apr 21, 2023
… given for the DT. (#25938) (#26011)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Fixed an issue where the entire comparison value was not given for the dt.

* Added test data

* Fixed test suite

* Fixed the mappings argument whose isArray attribute was not set.

* Update .devcontainer/devcontainer.json

---------

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
@spearmin10 spearmin10 deleted the MapPattern branch April 21, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome!
Projects
None yet
4 participants