Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAN-OS] fixed contextPath #26031

Merged
merged 4 commits into from Apr 24, 2023
Merged

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Apr 23, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Fixed an issue where the wrong context path was declared in the following commands: pan-os-create-address, pan-os-create-address-group, pan-os-list-address-groups.
    from 'Panorama.Addresses.Tag' to 'Panorama.Addresses.Tags'
    and from 'Panorama.AddressGroups.Tag' to 'Panorama.AddressGroups.Tags' according to the code.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@michal-dagan michal-dagan marked this pull request as ready for review April 23, 2023 09:10
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
Did you check if there are playbboks/test playbooks that based on these outputs?

@michal-dagan
Copy link
Contributor Author

Nice Did you check if there are playbboks/test playbooks that based on these outputs?

Yes, it appears that there are no playbooks/test playbooks based on this output.

@GuyAfik
Copy link
Contributor

GuyAfik commented Apr 23, 2023

@bziser @michal-dagan doesn't it break BC? will this require a force-merge?

@michal-dagan michal-dagan changed the title [PAN-OS] fix pan-os-create-address context path [PAN-OS] fixed contextPath Apr 24, 2023
@michal-dagan
Copy link
Contributor Author

michal-dagan commented Apr 24, 2023

@bziser @michal-dagan doesn't it break BC? will this require a force-merge?

@DeanArbel yes, it requires a force-merge

@DeanArbel DeanArbel merged commit 896e17d into master Apr 24, 2023
15 of 16 checks passed
@DeanArbel DeanArbel deleted the bugfix/issue-6322/pan-os-fix-context-path branch April 24, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants