Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ciac 4707/ LOLBas new feed #26042

Merged
merged 55 commits into from May 28, 2023
Merged

Ciac 4707/ LOLBas new feed #26042

merged 55 commits into from May 28, 2023

Conversation

AradCarmi
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

New feed for LOLBAS API.

dantavori
dantavori suggested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, see my notes

Packs/FeedLOLBAS/Author_image.png Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/TestPlaybooks/FeedLOLBas_test.yml Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/README.md Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/README.md Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/README.md Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/FeedLOLBAS.py Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/FeedLOLBAS.py Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/FeedLOLBAS.py Outdated Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/FeedLOLBAS.py Show resolved Hide resolved
Packs/FeedLOLBAS/Integrations/FeedLOLBAS/FeedLOLBAS.py Outdated Show resolved Hide resolved
@Ni-Knight
Copy link
Contributor

@AradCarmi Please change new fields filenames prefix to indicatorfield- and not incidentfield-.

@AradCarmi AradCarmi requested a review from ostolero as a code owner May 11, 2023 08:43
@AradCarmi
Copy link
Contributor Author

AradCarmi commented May 15, 2023 •
edited

Force merge was needed, the build fail on validate (IN122) because we updated the TLP selection colors and added the advanced section to feed fields.
This issue will be fixed in the PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonTypes pack version was bumped to 3.3.69.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

dantavori
dantavori approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job - approving but please resolve the one note above

@AradCarmi AradCarmi merged commit e241089 into master May 28, 2023
13 of 14 checks passed
@AradCarmi AradCarmi deleted the CIAC-4707/LOLBAS/NewFeed branch May 28, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ni-Knight Ni-Knight Ni-Knight left review comments

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@dantavori dantavori dantavori approved these changes

@michalgold michalgold Awaiting requested review from michalgold

@idovandijk idovandijk Awaiting requested review from idovandijk idovandijk is a code owner

@ostolero ostolero Awaiting requested review from ostolero

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved ForceMerge
Projects
None yet
Milestone
No milestone
5 participants
@AradCarmi @Ni-Knight @ShirleyDenkberg @content-bot @dantavori