Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXPANDR-3582 Resolving AWS-IAM bug #26086

Merged
merged 3 commits into from May 2, 2023

Conversation

capanw
Copy link
Contributor

@capanw capanw commented Apr 25, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Removing IAM related tasks from the AWS enrichment and remediation as we don't want to list out all the users present in the AWS account.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! labels Apr 25, 2023
@content-bot content-bot changed the base branch from master to contrib/capanw_aws-iam-bug April 25, 2023 07:40
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @samuelFain will know the proposed changes are ready to be reviewed.

@capanw
Copy link
Contributor Author

capanw commented Apr 26, 2023

For reference: Old GCP PR: #22877. The reason why we are removing the IAM AWS tasks is, they are not able to enrich the security group owners. Only the AWS account ID is being returned associated with the security group. Any security group regardless of who created it, will always have the same aws account ID and this doesn't really help to enrich the exact owner of security group.

@samuelFain
Copy link
Contributor

Hi @capanw, your PR will be reviewed shortly.
In the meanwhile, feel free to contact me for any questions/clarifications.
Thank you!

@samuelFain samuelFain added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label May 1, 2023
@content-bot
Copy link
Collaborator

content-bot commented May 1, 2023

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5166160

@samuelFain
Copy link
Contributor

Hi @capanw, since your PR mostly contain changes to playbooks, it will be also reviewed by a member of our security team.
Also, I noticed your forked repo is named chait-content instead of the recommended content, this is causing problems with the build process (you can see it for yourself here).
Could you please manually rename the repo using the following manual?
https://docs.github.com/en/repositories/creating-and-managing-repositories/renaming-a-repository

@samuelFain samuelFain added the pending-contributor The PR is pending the response of its creator label May 1, 2023
efelmandar
efelmandar previously approved these changes May 1, 2023
Copy link
Contributor

@efelmandar efelmandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the changes and PR is approved @samuelFain

@efelmandar efelmandar self-requested a review May 1, 2023 14:26
@efelmandar efelmandar dismissed their stale review May 1, 2023 14:27

waiting for shmuel

@capanw
Copy link
Contributor Author

capanw commented May 1, 2023

Hello @samuelFain, Thanks for pointing it out. I updated the name of my forked repo.

@samuelFain samuelFain added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels May 2, 2023
@samuelFain samuelFain merged commit 0b5b125 into demisto:contrib/capanw_aws-iam-bug May 2, 2023
21 of 22 checks passed
samuelFain pushed a commit that referenced this pull request May 2, 2023
Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
TalNos pushed a commit that referenced this pull request May 3, 2023
Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
4 participants