Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cybersixgill darkfeed add subfeeds ids #26110

Merged
merged 10 commits into from Apr 30, 2023
Merged

Cybersixgill darkfeed add subfeeds ids #26110

merged 10 commits into from Apr 30, 2023

Conversation

syed-loginsoft
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

A few sentences describing the overall goals of the pull request's commits.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Apr 27, 2023
@content-bot content-bot changed the base branch from master to contrib/syed-loginsoft_cybersixgill-darkfeed-add-subfeeds-ids April 27, 2023 14:31
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @GuyAfik will know the proposed changes are ready to be reviewed.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Apr 30, 2023
@kgal-pan kgal-pan self-assigned this Apr 30, 2023
@GuyAfik GuyAfik added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 30, 2023
@content-bot
Copy link
Collaborator

content-bot commented Apr 30, 2023

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5154217

@GuyAfik GuyAfik removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Apr 30, 2023
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syed-loginsoft looks great, thanks for the contribution!

@GuyAfik GuyAfik merged commit dff02a7 into demisto:contrib/syed-loginsoft_cybersixgill-darkfeed-add-subfeeds-ids Apr 30, 2023
20 checks passed
GuyAfik added a commit that referenced this pull request Apr 30, 2023
* Update .devcontainer.json name

* Added darkfeed feed ids from 29 to 56

* Updated release notes

* update docker image version and yaml formatting

* Updated release notes

* Update .devcontainer/devcontainer.json

---------

Co-authored-by: syed-loginsoft <97145640+syed-loginsoft@users.noreply.github.com>
Co-authored-by: syed-loginsoft <syed-loginsoft@users.noreply.github.com>
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Partner
Projects
None yet
4 participants