Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] EXPANDR-3750 - Serviceownership enrichment hotfix #26123

Merged
merged 5 commits into from May 2, 2023
Merged

[ASM] EXPANDR-3750 - Serviceownership enrichment hotfix #26123

merged 5 commits into from May 2, 2023

Conversation

capanw
Copy link
Contributor

@capanw capanw commented Apr 28, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-3750. Fixing the service ownership playbook missing issue.

Description

Fixing the service ownership playbook missing issue.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@BigEasyJ
Update Enrichment playbook
a162a57 
- Fix Service Ownership playbook task by adding correct playbook.
@BigEasyJ
Add release notes
e5de2eb
@capanw capanw changed the title EXPANDR-3750 - Serviceownership enrichment hotfix [ASM] EXPANDR-3750 - Serviceownership enrichment hotfix Apr 28, 2023
@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Apr 28, 2023
@content-bot content-bot changed the base branch from master to contrib/BigEasyJ_serviceownership_enrichment_hotfix April 28, 2023 17:06
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed.

capanw
capanw commented Apr 28, 2023
View reviewed changes
Copy link
Contributor Author

@capanw capanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BigEasyJ
BigEasyJ approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@BigEasyJ BigEasyJ left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #25927

Noting that demisto-sdk format changed:

  • script changed to scriptName
  • playbookId to playbookName

Note: Please refer to our Pull Request Guidelines for XSOAR Contribution and Xpanse Remediation teams for merging PRs only related to Packs/CortexAttackSurfaceManagement.

@BigEasyJ
Copy link
Contributor

BigEasyJ commented Apr 28, 2023 •
edited

Also, the contribution form has been completed.

@merit-maita
Please merge as soon as possible.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Apr 30, 2023
@merit-maita merit-maita added docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Apr 30, 2023
@content-bot
Copy link
Collaborator

content-bot commented Apr 30, 2023 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5158847

@BigEasyJ
Copy link
Contributor

BigEasyJ commented May 1, 2023

@merit-maita also please refer to our Pull Request Guidelines for XSOAR Contribution and Xpanse Remediation teams for merging PRs only related to Packs/CortexAttackSurfaceManagement.

@merit-maita merit-maita added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels May 1, 2023
@merit-maita merit-maita merged commit e3cc210 into demisto:contrib/BigEasyJ_serviceownership_enrichment_hotfix May 2, 2023
18 checks passed
@content-bot content-bot mentioned this pull request May 2, 2023
Merged
11 tasks
merit-maita added a commit that referenced this pull request May 2, 2023
@content-bot @capanw
@BigEasyJ @merit-maita
[ASM] EXPANDR-3750 - Serviceownership enrichment hotfix (#26123) (#26232
fff8567 
)

* Update Enrichment playbook

- Fix Service Ownership playbook task by adding correct playbook.

* Add release notes

---------

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
TalNos pushed a commit that referenced this pull request May 3, 2023
@content-bot @capanw
@BigEasyJ @merit-maita @TalNos
[ASM] EXPANDR-3750 - Serviceownership enrichment hotfix (#26123) (#26232
78e4eb6 
)

* Update Enrichment playbook

- Fix Service Ownership playbook task by adding correct playbook.

* Add release notes

---------

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: bigeasyj <janny@paloaltonetworks.com>
Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com>
@BigEasyJ BigEasyJ deleted the serviceownership_enrichment_hotfix branch July 31, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigEasyJ BigEasyJ BigEasyJ approved these changes

@merit-maita merit-maita merit-maita approved these changes

Assignees

@merit-maita merit-maita

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
4 participants
@capanw @content-bot @BigEasyJ @merit-maita