Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cisco integrations - fix format_timestamp method #26140

Merged
merged 10 commits into from May 3, 2023

Conversation

adi88d
Copy link
Contributor

@adi88d adi88d commented Apr 30, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue
fixes: link to the issue

Description

For both CiscoSMA.py and CiscoEmailSecurityApplianceIronPortV2.py :

  • remove the methods : format_last_run, format_quarantine_timestamp.
  • add to format_timestamp method the arg output_format.
  • fix format_timestamp method to support timestamps with time zone like (GMT +01:00).
  • use arg_to_datetime instead of datetime.strptime in format_timestamp method.
  • add tests to format_timestamp.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@adi88d adi88d requested a review from DeanArbel April 30, 2023 14:12
@adi88d adi88d changed the title CiscoSMA - fix format_timestamp method Cisco integrations - fix format_timestamp method Apr 30, 2023
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • IronPort pack version was bumped to 2.0.6.
  • CiscoSMA pack version was bumped to 1.1.11.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@adi88d adi88d merged commit 790036c into master May 3, 2023
14 of 16 checks passed
@adi88d adi88d deleted the cisco-format_timestamp-fix branch May 3, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants