Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new transformers which are MakePair, SortBy and DedupBy #26237

Merged
merged 1 commit into from May 2, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@spearmin10

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

Added new transformers which are MakePair, SortBy and DedupBy.
On DedupBy, there is a similer script which is DeduplicateValuesbyKey, but it cannot be used on the classifier or mappers since it's not a transformer, and also DedupBy can be used no matter what data types are.

Screenshots

https://paloaltonetworks.zoom.us/rec/share/62h7KHcAOcLzFcaiH0M7N4VUqtMMJZV0kFOL-5PXgbfawp1TuQK4pGsy82ZVrV9E.sKHPVZtpqJeaZbFN
PassCode: %D&%L.y4jM

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Added SortBy, MakePair and DedupBy.

* Update RN

* Improve the algorithm

* Improved alrorithm

* Fixed lint errors

* Improved algorithm

* Fixed them following to the reviewer's comments.

* Fix misspells

---------

Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com>
Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. post-demo Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator labels May 2, 2023
@samuelFain samuelFain merged commit 0c57d87 into master May 2, 2023
31 checks passed
@samuelFain samuelFain deleted the contrib/spearmin10_Transformers-1 branch May 2, 2023 13:05
TalNos pushed a commit that referenced this pull request May 3, 2023
#26237)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Added SortBy, MakePair and DedupBy.

* Update RN

* Improve the algorithm

* Improved alrorithm

* Fixed lint errors

* Improved algorithm

* Fixed them following to the reviewer's comments.

* Fix misspells

---------

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com>
Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
3 participants