Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RecordedFuture, RunZero, SafeNetTrustedAccess, SentinelOne] Fix LastRun setting in event collector #26246

Merged
merged 9 commits into from May 4, 2023

Conversation

yaakovpraisler
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

relates: https://jira-hq.paloaltonetworks.local/browse/CIAC-6238

Description

Fixed the LastRun setting to be after sending events to XSIAM in the event collector.
In packs: RecordedFuture, RunZero, SafeNetTrustedAccess, SentinelOne

@github-actions
Copy link

github-actions bot commented May 2, 2023

Your contributed RecordedFuture pack has been modified on files:

Packs/RecordedFuture/Integrations/RecordedFutureEventCollector/RecordedFutureEventCollector.yml
Packs/RecordedFuture/Integrations/RecordedFutureEventCollector/RecordedFutureEventCollector.py
Packs/RecordedFuture/pack_metadata.json
Packs/RecordedFuture/ReleaseNotes/1_5_2.md
Please review the changes here

@yaakovpraisler
Copy link
Contributor Author

Build fail is:

file: Packs/RecordedFuture/Integrations/RecordedFutureEventCollector/RecordedFutureEventCollector.py unittests coverage should reach at least 86.34 currently 81.93.
file: Packs/SentinelOne/Integrations/SentinelOneEventCollector/SentinelOneEventCollector.py unittests coverage should reach at least 87.07 currently 85.98.

@dantavori - We need a force merge here

@dantavori dantavori merged commit f4bf23b into master May 4, 2023
13 of 16 checks passed
@dantavori dantavori deleted the collectors-setLastRun-fix-unify-phase1 branch May 4, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants