integration fixes and improvements #26271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* integration fixes and improvements * changed content pack version get * add rn and bump metadata * add rn * updated release notes * added unit test * Update Packs/FeedIntel471/Integrations/Intel471MalwareIndicator/Intel471MalwareIndicator.py Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * update test_fetch_indicators test * Update Packs/FeedIntel471/Integrations/Intel471MalwareIndicator/Intel471MalwareIndicator.py Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * Update Packs/FeedIntel471/Integrations/Intel471MalwareIndicator/Intel471MalwareIndicator.yml Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * Update Packs/FeedIntel471/ReleaseNotes/2_0_18.md Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * Update Packs/FeedIntel471/pack_metadata.json Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * change release number * revert to original get method * test_module and get_indicators_command fixes * pan suggested changes * removed obsolete code * removed whitespace * cr fixes + test fixes --------- Co-authored-by: GuyAfik <guyafik11@gmail.com> Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
content-bot
added
Contribution
GuyAfik
reviewed
May 3, 2023
GuyAfik
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@rhallick
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Recent changes to the XSOAR platform have created issues for the integrations within the Intel 471 Content Pack. These changes resolve those issues, along with some other performance improvements.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have