Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reliability to DBotPredictURLPhishing #26279

Merged
merged 10 commits into from May 21, 2023
Merged

Add reliability to DBotPredictURLPhishing #26279

merged 10 commits into from May 21, 2023

Conversation

DinaMeylakh
Copy link
Contributor

@DinaMeylakh DinaMeylakh commented May 3, 2023 •
edited

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Must have

  • Tests
  • Documentation

@DinaMeylakh
Copy link
Contributor Author

Uploading for review now, will add unittests and documentation next week.
Checked the correction on xsoar and it works :)
@ShahafBenYakir you can review now or wait until finaliziation

ShahafBenYakir
ShahafBenYakir reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
let's also not forget to add these to docs

Packs/PhishingURL/Scripts/DBotPredictURLPhishing/DBotPredictURLPhishing.yml Show resolved Hide resolved
Packs/PhishingURL/Scripts/DBotPredictURLPhishing/DBotPredictURLPhishing.py Outdated Show resolved Hide resolved
@DinaMeylakh DinaMeylakh requested a review from bakatzir May 10, 2023 16:13
@DinaMeylakh DinaMeylakh requested review from ShahafBenYakir and removed request for bakatzir May 10, 2023 16:17
@ShirleyDenkberg ShirleyDenkberg self-assigned this May 10, 2023
@ShirleyDenkberg
Copy link
Contributor

@bakatzir @ShahafBenYakir Doc review completed.

@ShahafBenYakir
Copy link
Contributor

We have decided to wait with the docker update for now, and so I am ignoring the docker validation error.

@ShahafBenYakir ShahafBenYakir merged commit 99a2979 into master May 21, 2023
14 of 16 checks passed
@ShahafBenYakir ShahafBenYakir deleted the dbotpredicturl_add_reliablity branch May 21, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakatzir bakatzir bakatzir left review comments

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved ForceMerge
Projects
None yet
Milestone
No milestone
4 participants
@DinaMeylakh @ShirleyDenkberg @ShahafBenYakir @bakatzir