Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - Expander - Update service owner playbook #26287

Conversation

BigEasyJ
Copy link
Contributor

@BigEasyJ BigEasyJ commented May 3, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

#25927

Description

  • Updates Pack ReadMe
  • Fixes an issue where service owner were not found.
  • Updates the Cortex ASM - Service Ownership playbook to check for GCP IAM integration and for the existence of service owners.

Screenshots

Cortex_ASM_-_Service_Ownership

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

- Fix an issue where service owner were not found.
- Update the Cortex ASM - Service Ownership playbook to check for GCP IAM integration and for the existence of service owners.
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! labels May 3, 2023
@content-bot content-bot changed the base branch from master to contrib/BigEasyJ_update_service_owner_playbook May 3, 2023 21:11
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @samuelFain will know the proposed changes are ready to be reviewed.

@BigEasyJ
Copy link
Contributor Author

BigEasyJ commented May 3, 2023

Copy link
Contributor

@kball-pa kball-pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


##### Cortex ASM - Service Ownership

- Fixed an issue where service owner were not found.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo, "service owners"

Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigEasyJ , looked this over and it is good to go!

@johnnywilkes
Copy link
Contributor

@samuelFain, this is an Xpanse only pack change and we have approved internally. Please merge when possible.

@samuelFain samuelFain added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label May 4, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5184819

@samuelFain samuelFain merged commit 121dc61 into demisto:contrib/BigEasyJ_update_service_owner_playbook May 4, 2023
20 of 21 checks passed
samuelFain pushed a commit that referenced this pull request May 4, 2023
* Update Cortex ASM - Service Ownership playbook

- Fix an issue where service owner were not found.
- Update the Cortex ASM - Service Ownership playbook to check for GCP IAM integration and for the existence of service owners.

* Update PNG

* Update pack ReadMe

* Update Cortex ASM - Service Ownership task description and version

* Update release notes

Fix typo

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
@BigEasyJ BigEasyJ deleted the update_service_owner_playbook branch July 31, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
5 participants