Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] EXPANDR-3582 - Prisma cloud changes and Emails from Tags changes. #26301

Merged
merged 11 commits into from May 7, 2023
Merged

[ASM] EXPANDR-3582 - Prisma cloud changes and Emails from Tags changes. #26301

merged 11 commits into from May 7, 2023

Conversation

capanw
Copy link
Contributor

@capanw capanw commented May 4, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-3582
https://jira-hq.paloaltonetworks.local/browse/EXPANDR-3411

Description

Merging Prisma cloud playbooks into Cortex ASM pack and Adding new enhancement where we now extract email ownership from tags.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels May 4, 2023
@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label May 4, 2023
@content-bot content-bot changed the base branch from master to contrib/capanw_prisma-iam-aws-changes-wed May 4, 2023 07:25
@content-bot content-bot requested a review from GuyAfik May 4, 2023 07:26
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @GuyAfik will know the proposed changes are ready to be reviewed.

johnnywilkes
johnnywilkes suggested changes May 4, 2023
View reviewed changes
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things to look into

...rfaceManagement/Integrations/CortexAttackSurfaceManagement/CortexAttackSurfaceManagement.yml Outdated
@@ -370,7 +370,7 @@ script:
- contextPath: ASM.RemediationRule.created_at
description: Date the rule was created.
type: Date
dockerimage: demisto/python3:3.10.11.54132
dockerimage: demisto/python3:3.10.11.56857
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , Im not sure why docker images got updated for integration and all automations, but I would undo those changes to make the PR more simple and resolve the validation errors you have

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnnywilkes, Demisot-sdk validate was throwing errors on all automations to update dockerimage. Let me undo these changes, and see if it still throws errors here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you revert the fromversion back to what is was before and therefore the files aren't changed, it shouldn't throw validation errors anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Tests/Marketplace/core_packs_xpanse_list.json Show resolved Hide resolved
Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Enrichment.yml Outdated Show resolved Hide resolved
@capanw capanw force-pushed the prisma-iam-aws-changes-wed branch from 7cd932b to 6fff5a7 Compare May 4, 2023 15:40
@johnnywilkes
Copy link
Contributor

@GuyAfik , is something not right with the build? https://github.com/demisto/content/actions/runs/4889973341/jobs/8728970663?pr=26301

Haven't seen these errors before

@capanw capanw force-pushed the prisma-iam-aws-changes-wed branch from d0f01b1 to f5c3415 Compare May 5, 2023 15:34
johnnywilkes
johnnywilkes approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @capanw ! Approved, but I expect @GuyAfik to have to look over the small changes not in ASM pack

@GuyAfik GuyAfik added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. docs-approved labels May 7, 2023
@content-bot
Copy link
Collaborator

content-bot commented May 7, 2023 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5208711

GuyAfik
GuyAfik approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! nice work!

@GuyAfik GuyAfik merged commit e525cd7 into demisto:contrib/capanw_prisma-iam-aws-changes-wed May 7, 2023
21 of 23 checks passed
@content-bot content-bot mentioned this pull request May 7, 2023
Merged
11 tasks
GuyAfik added a commit that referenced this pull request May 9, 2023
@content-bot @capanw @GuyAfik
[ASM] EXPANDR-3582 - Prisma cloud changes and Emails from Tags change…
2f3fe9b 
…s. (#26355)

* [ASM] EXPANDR-3582 - Prisma cloud changes and Emails from Tags changes. (#26301)

* Prisma cloud changes and Emails from Tags changes.

* Adding absolute path

* Updated wording in release notes

* Fixing few changes

* Empty-Commit

* Empty-Commit

* Reverting back to old versions 6.5.0

* Updating release notes version

* test for dan

* revert poetry changes

* update

* bump rn

* add packs to expanse marketplace

---------

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: GuyAfik <guyafik11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnywilkes johnnywilkes johnnywilkes approved these changes

@GuyAfik GuyAfik GuyAfik approved these changes

Assignees

@GuyAfik GuyAfik

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
4 participants
@capanw @content-bot @johnnywilkes @GuyAfik