Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreproccessEmail: correct the if condition #26361

Merged

Conversation

ilappe
Copy link
Contributor

@ilappe ilappe commented May 7, 2023

Related Issues

fixes: link to the issue

Description

when the emailsubject field of the incident are None the script fail due to incorrect if condition

Screenshots

updated unit test failed before the fix
image

updated unit test pass after the fix
image

@ilappe ilappe requested a review from DeanArbel May 7, 2023 12:33
@ilappe ilappe self-assigned this May 7, 2023
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ilappe ilappe merged commit 81b717d into master May 7, 2023
17 of 19 checks passed
@ilappe ilappe deleted the ilappe/XSUP-24033/PreprocessEmail/correct_if_condition branch May 7, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants