New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeleteReportedEmail (script) - Improve Error Handling #26363
DeleteReportedEmail (script) - Improve Error Handling #26363
Conversation
3f0cc36
to
e8b9005
Compare
e8b9005
to
1988170
Compare
NoneType
is not iterable" ErrorThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Packs/Phishing/Scripts/DeleteReportedEmail/DeleteReportedEmail_test.py
Outdated
Show resolved
Hide resolved
Packs/Phishing/Scripts/DeleteReportedEmail/DeleteReportedEmail.py
Outdated
Show resolved
Hide resolved
Packs/Phishing/Scripts/DeleteReportedEmail/DeleteReportedEmail.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great (and fast) work!
Please see my comments.
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, please add my suggestion
Co-authored-by: Ido van Dijk <43602124+idovandijk@users.noreply.github.com>
@bziser @idovandijk Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Status
Related Issues
fixes: link to the issue
Description
If user-id data (
reportedemailto
) is missing from incident data, print a proper error early on, instead of theTypeError: argument of type 'NoneType' is not iterable
error currently received.