Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteReportedEmail (script) - Improve Error Handling #26363

Merged
merged 15 commits into from May 18, 2023

Conversation

MichaelYochpaz
Copy link
Contributor

@MichaelYochpaz MichaelYochpaz commented May 7, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

If user-id data (reportedemailto) is missing from incident data, print a proper error early on, instead of the TypeError: argument of type 'NoneType' is not iterable error currently received.

@MichaelYochpaz MichaelYochpaz force-pushed the XSUP-24029/deletereportedemail-bugfix branch from 3f0cc36 to e8b9005 Compare May 8, 2023 07:38
@MichaelYochpaz MichaelYochpaz force-pushed the XSUP-24029/deletereportedemail-bugfix branch from e8b9005 to 1988170 Compare May 10, 2023 12:51
@MichaelYochpaz MichaelYochpaz changed the title DeleteReportedEmail (script) - Fix "NoneType is not iterable" Error DeleteReportedEmail (script) - Improve Error Handling May 10, 2023
@MichaelYochpaz MichaelYochpaz marked this pull request as ready for review May 10, 2023 12:52
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great (and fast) work!
Please see my comments.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Phishing pack version was bumped to 3.5.17.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, please add my suggestion

Co-authored-by: Ido van Dijk <43602124+idovandijk@users.noreply.github.com>
@ShirleyDenkberg
Copy link
Contributor

@bziser @idovandijk Doc review completed.

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@MichaelYochpaz MichaelYochpaz merged commit a098619 into master May 18, 2023
14 checks passed
@MichaelYochpaz MichaelYochpaz deleted the XSUP-24029/deletereportedemail-bugfix branch May 18, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants