Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] EXPANDR-3686 - Added sleep and retry changes #26555

Merged
merged 5 commits into from May 18, 2023
Merged

[ASM] EXPANDR-3686 - Added sleep and retry changes #26555

merged 5 commits into from May 18, 2023

Conversation

capanw
Copy link
Contributor

@capanw capanw commented May 16, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-3686

Description

Adding a sleep task to accommodate for delayed service information.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels May 16, 2023
@capanw capanw marked this pull request as draft May 16, 2023 07:27
@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label May 16, 2023
@content-bot content-bot changed the base branch from master to contrib/capanw_no-service May 16, 2023 07:28
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @thefrieddan1 will know the proposed changes are ready to be reviewed.

johnnywilkes
johnnywilkes approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , looks good to me.

Need to figure out what we will do with versioning

@capanw capanw marked this pull request as ready for review May 16, 2023 20:02
@capanw
Copy link
Contributor Author

capanw commented May 16, 2023

@johnnywilkes, updated the version number and its good to go.

@johnnywilkes
Copy link
Contributor

@thefrieddan1, this is an ASM only change and we have approved internally, please merge when possible.

@johnnywilkes
Copy link
Contributor

@thefrieddan1 , we fixed the validation error. Can you please merge today? This is holding up another PR: #26444

@johnnywilkes johnnywilkes mentioned this pull request May 17, 2023
Merged
11 tasks
@johnnywilkes
Copy link
Contributor

@thefrieddan1 after talking to @ShacharKidor , this is not a blocker for #26444, however, if this is merged 2nd, the release number will have to change

@thefrieddan1 thefrieddan1 added docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels May 17, 2023
@content-bot
Copy link
Collaborator

content-bot commented May 17, 2023 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5290127

@thefrieddan1 thefrieddan1 merged commit 66bbee9 into demisto:contrib/capanw_no-service May 18, 2023
23 checks passed
@content-bot content-bot mentioned this pull request May 18, 2023
Merged
11 tasks
thefrieddan1 pushed a commit that referenced this pull request May 18, 2023
@content-bot @capanw @johnnywilkes
[ASM] EXPANDR-3686 - Added sleep and retry changes (#26555) (#26608)
8739380 
* Added sleep and retry changes

* Updated versions

* Update Cortex_ASM_-_Enrichment.yml

change fromVer

---------

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefrieddan1 thefrieddan1 thefrieddan1 approved these changes

@johnnywilkes johnnywilkes johnnywilkes approved these changes

Assignees

@thefrieddan1 thefrieddan1

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
4 participants
@capanw @content-bot @johnnywilkes @thefrieddan1