Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] EXPANDR-4141 Fixed Tag email key #26647

Merged
merged 5 commits into from May 23, 2023

Conversation

capanw
Copy link
Contributor

@capanw capanw commented May 20, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-4141

Description

The email information in Cortex ASM - Enrichment playbook where we are extracting from Tags are being stored in Name key in asmserviceowner. Moving this to store in Email key.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! labels May 20, 2023
@content-bot content-bot changed the base branch from master to contrib/capanw_fix-email May 20, 2023 03:27
@capanw
Copy link
Contributor Author

capanw commented May 20, 2023

There is another PR that is currently open for this pack. Version numbers needs to be updated if this PR goes before 26444.

@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @michal-dagan will know the proposed changes are ready to be reviewed.

@capanw capanw changed the title Fixed Tag email key [ASM] EXPANDR-4141 Fixed Tag email key May 20, 2023
@michal-dagan michal-dagan requested review from efelmandar and removed request for efelmandar May 21, 2023 06:14
@michal-dagan michal-dagan added the pending-contributor The PR is pending the response of its creator label May 21, 2023
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , one small thing to think about

Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , looks good. @michal-dagan , this is approved from Xpanse side, please merge when possible.

@michal-dagan michal-dagan added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label May 22, 2023
@content-bot
Copy link
Collaborator

content-bot commented May 22, 2023

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5323802

@michal-dagan michal-dagan merged commit 972993f into demisto:contrib/capanw_fix-email May 23, 2023
23 checks passed
michal-dagan pushed a commit that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
5 participants