Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "zip" as a valid gTLD #26702

Merged
merged 19 commits into from May 24, 2023
Merged

Adding "zip" as a valid gTLD #26702

merged 19 commits into from May 24, 2023

Conversation

Ni-Knight
Copy link
Contributor

@Ni-Knight Ni-Knight commented May 22, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-24463

Description

As zip is now a valid gTLD we need to not filter it out.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.11.78.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.11.79.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@bakatzir
Copy link
Member

Dror and I talked about it and approved this change going forward. we will monitor the feedback from the field.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.11.80.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@Ni-Knight Ni-Knight requested a review from bakatzir May 24, 2023 07:21
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@Ni-Knight Ni-Knight merged commit 8465bcb into master May 24, 2023
16 checks passed
@Ni-Knight Ni-Knight deleted the DRA-XSUP24463 branch May 24, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants