Netmiko #26716
Merged
Netmiko #26716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated documentation and formatted code per XSOAR-supported standards * Updated Netmiko_description * Updated Netmiko_description * Spelling errors * Initial PR update * Updated per initial PR feedback * Added tests parameter * Refined unit tests * Whitespace cleanup * Resolved markdown table generation issues * Updated documentation * Documentation tuning * Doc updates * Doc update testing * Docs * Doc Cleanup * Code refinement per reviewer comments * Update Release Notes * Update RN * Test commit * Undo test * Code Coverage * Code coverage refinement * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Flake8 Corrections * Removed unneeded pragma's * Comment cleanup * Cleanup --------- Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
| required: true | ||
| defaultvalue: null | ||
| type: 9 | ||
| additionalinfo: null |
There was a problem hiding this comment.
How is this additional information? This is not helpful. Should be deleted
There was a problem hiding this comment.
null means there's no value for this field, it's not visible to anyone.
|
@dantavori Doc review completed. |
ostolero
reviewed
May 23, 2023
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
dantavori
approved these changes
Jun 1, 2023
DNRRomero
pushed a commit
to DNRRomero/xsoar
that referenced
this pull request
Jun 6, 2023
* Netmiko (demisto#26078) * Updated documentation and formatted code per XSOAR-supported standards * Updated Netmiko_description * Updated Netmiko_description * Spelling errors * Initial PR update * Updated per initial PR feedback * Added tests parameter * Refined unit tests * Whitespace cleanup * Resolved markdown table generation issues * Updated documentation * Documentation tuning * Doc updates * Doc update testing * Docs * Doc Cleanup * Code refinement per reviewer comments * Update Release Notes * Update RN * Test commit * Undo test * Code Coverage * Code coverage refinement * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Code Coverage * Flake8 Corrections * Removed unneeded pragma's * Comment cleanup * Cleanup --------- Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * cr notes * update conf.json * docker update, yml fixes and removed tpb * try running tpb again * fix tpb * fix sshkey auth --------- Co-authored-by: Josh Levine <76795471+TerminalFin@users.noreply.github.com> Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Dan Tavori <dtavori@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@TerminalFin
Initial submission to uplift this content pack to officially supported status. I request assistance in developing the unit tests so that I can meet the XSOAR contribution standards.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have