DIsplayHtmlWithImages: added the dynamic section script #26945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2023
…pe/CRTX-81882/Add_dynamic_section_for_html_images
idovandijk
requested changes
May 28, 2023
| email_cc = custom_fields.get('emailcc') | ||
| email_to = custom_fields.get('emailto') | ||
| email_subject = custom_fields.get('emailsubject') | ||
| email_html = custom_fields.get('renderedhtmll', '') or \ |
There was a problem hiding this comment.
Please fix renderedhtmll to be renderedhtml
idovandijk
requested changes
May 28, 2023
There was a problem hiding this comment.
Please note that if all fields are empty it's showing some data. It should be empty instead:
Also when Rendered HTML was empty and Email HTML had data, the dynamic section showed all the "None" values and only then displayed the data that it was supposed to display:
Other than this it looked fine in my tests, great job
…pe/CRTX-81882/Add_dynamic_section_for_html_images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CRTX-81822
Description
Added a new dynamic-section script in order to display HTML with image reference as
cid:image_idScreenshots
Minimum version of Cortex XSOAR