Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials to type 9- part 1 #26973

Merged
merged 34 commits into from Jun 1, 2023
Merged

Align credentials to type 9- part 1 #26973

merged 34 commits into from Jun 1, 2023

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented May 24, 2023

Status

  • In Progress

Related Issues

related: https://jira-hq.paloaltonetworks.local/browse/CIAC-5274?filter=-1

Description

update the integration to type9:

  • Thinkst Canary
  • workday
  • Cisco-umbrella-enforcement

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag maimorag changed the title Type9 effort Align credentials to type 9 May 28, 2023
@maimorag maimorag changed the title Align credentials to type 9 Align credentials to type 9- part 1 May 28, 2023
@maimorag maimorag requested a review from Shellyber May 28, 2023 14:40
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments regarding all integrations please

@maimorag maimorag requested a review from Shellyber May 29, 2023 12:58
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Packs/Workday/Integrations/Workday/Workday.py Outdated Show resolved Hide resolved
maimorag and others added 3 commits May 31, 2023 10:29
Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
@maimorag maimorag requested a review from Shellyber May 31, 2023 15:38
@maimorag maimorag merged commit f1d50d0 into master Jun 1, 2023
13 of 14 checks passed
@maimorag maimorag deleted the type9_effort branch June 1, 2023 08:20
DNRRomero pushed a commit to DNRRomero/xsoar that referenced this pull request Jun 6, 2023
* switching to type 9

* more integration thinkst cnaray

* more changes

* fix errors

* fix

* fix

* adding deprecated

* rl

* fix

* valid

* space

* rl fix

* fixes

* updated to required: false

* fix cr

* remove space

* fix unit tests

* fix ctred

* fix unit test

* adding tests

* removing note

* Update Packs/Workday/Integrations/Workday/Workday.py

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* fix

* change test

* Update Packs/Workday/Integrations/Workday/Workday.py

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* updates

* add test

* remove info

* reverting code changes

---------

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants