Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores- part 3 #27023

Merged
merged 16 commits into from May 31, 2023
Merged

Conversation

maimorag
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag maimorag requested a review from Shellyber May 28, 2023 14:56
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new addition should be first - see my comment, change everywhere it is needed

@maimorag maimorag requested a review from Shellyber May 29, 2023 14:09
@maimorag maimorag requested a review from Shellyber May 30, 2023 14:54
@maimorag maimorag merged commit 86b482a into master May 31, 2023
15 of 16 checks passed
@maimorag maimorag deleted the align_credentials_stores_part_3 branch May 31, 2023 07:32
DNRRomero pushed a commit to DNRRomero/xsoar that referenced this pull request Jun 6, 2023
* Google Key Management Service - moving to type 9

* update to type 9- BeyondTrust Password Safe

* type 9 changes MailListener - POP3

* RL

* undo changes

* update to required: false

* fix

* trying fix

* fix error

* false

* fix tests errors

* cr

* spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants