Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panOS] Add Security Rule does not take list as paramter #27040

Merged
merged 20 commits into from Jun 9, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Packs/PAN-OS/Integrations/Panorama/Panorama.py
Expand Up @@ -629,7 +629,7 @@ def set_xpath_network(template: str = None) -> Tuple[str, Optional[str]]:
def prepare_security_rule_params(api_action: str = None, rulename: str = None, source: Any = None,
destination: Any = None, negate_source: str = None,
negate_destination: str = None, action: str = None, service: List[str] = None,
disable: str = None, application: List[str] = None, source_user: str = None,
disable: str = None, application: List[str] = None, source_user: List[str] = None,
category: List[str] = None, from_: str = None, to: str = None, description: str = None,
target: str = None, log_forwarding: str = None,
disable_server_response_inspection: str = None, tags: List[str] = None,
Expand All @@ -652,7 +652,7 @@ def prepare_security_rule_params(api_action: str = None, rulename: str = None, s
+ add_argument_list(destination, 'destination', True, True)
+ add_argument_list(application, 'application', True)
+ add_argument_list(category, 'category', True)
+ add_argument_open(source_user, 'source-user', True)
+ add_argument_list(source_user, 'source-user', True)
+ add_argument_list(from_, 'from', True, True) # default from will always be any
+ add_argument_list(to, 'to', True, True) # default to will always be any
+ add_argument_list(service, 'service', True, True)
Expand Down Expand Up @@ -3651,7 +3651,7 @@ def panorama_create_rule_command(args: dict):
disable = args.get('disable')
categories = argToList(args.get('category'))
application = argToList(args.get('application'))
source_user = args.get('source_user')
source_user = argToList(args.get('source_user'))
disable_server_response_inspection = args.get('disable_server_response_inspection')
description = args.get('description')
target = args.get('target')
Expand Down
12 changes: 6 additions & 6 deletions Packs/PAN-OS/Integrations/Panorama/Panorama.yml
Expand Up @@ -1595,12 +1595,12 @@ script:
- Yes
- No
- defaultValue: any
description: A comma-separated list of application object names for the rule. to create.
description: A comma-separated list of application object names for the rule to create.
isArray: true
name: application
- defaultValue: any
description: The source user for the rule to create.
- description: A comma-separated list of source users for the rule to create.
name: source_user
isArray: true
- auto: PREDEFINED
description: The pre-rule or post-rule (Panorama instances).
name: pre_post
Expand Down Expand Up @@ -5027,12 +5027,12 @@ script:
- Yes
- No
- defaultValue: any
description: A comma-separated list of application object names for the rule. to create.
description: A comma-separated list of application object names for the rule to create.
isArray: true
name: application
- defaultValue: any
description: The source user for the rule to create.
- description: A comma-separated list of source users for the rule to create.
samuelFain marked this conversation as resolved.
Show resolved Hide resolved
name: source_user
isArray: true
- auto: PREDEFINED
description: The pre-rule or post-rule (Panorama instances).
name: pre_post
Expand Down
6 changes: 6 additions & 0 deletions Packs/PAN-OS/ReleaseNotes/1_17_5.md
@@ -0,0 +1,6 @@

#### Integrations

##### Palo Alto Networks PAN-OS

- Updated the *pan-os-create-rule* command to support a comma-separated list of values for its **source_user** argument.
2 changes: 1 addition & 1 deletion Packs/PAN-OS/pack_metadata.json
Expand Up @@ -2,7 +2,7 @@
"name": "PAN-OS by Palo Alto Networks",
"description": "Manage Palo Alto Networks Firewall and Panorama. For more information see Panorama documentation.",
"support": "xsoar",
"currentVersion": "1.17.4",
"currentVersion": "1.17.5",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down