Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cs indicator feed bug #27050

Merged
merged 7 commits into from May 31, 2023
Merged

Cs indicator feed bug #27050

merged 7 commits into from May 31, 2023

Conversation

israelpoli
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CRTX-83523

Description

Setting the feed to incremental feed
Setting the First Fetch Time parameter to be mandatory

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

Docs review fixes

Co-authored-by: Andrew Shamah <42912128+amshamah419@users.noreply.github.com>
Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a Tech Writer (@ShirleyDenkberg ) review the texts.

@yuvalbenshalom yuvalbenshalom merged commit 6ccb7bc into master May 31, 2023
12 of 14 checks passed
@yuvalbenshalom yuvalbenshalom deleted the cs_indicator_feed_bug branch May 31, 2023 10:58
DNRRomero pushed a commit to DNRRomero/xsoar that referenced this pull request Jun 6, 2023
* set feedIncremental and change the First Fetch Time to required

* add RN and warning comment

* update docker

* commit

* Apply suggestions from code review

Docs review fixes

Co-authored-by: Andrew Shamah <42912128+amshamah419@users.noreply.github.com>

* fix syntax

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
Co-authored-by: Andrew Shamah <42912128+amshamah419@users.noreply.github.com>
Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants