EWS O365 Fix for attachment XML error #27096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalbenshalom
approved these changes
May 31, 2023
DNRRomero
pushed a commit
to DNRRomero/xsoar
that referenced
this pull request
Jun 6, 2023
* Catch and release the wild SAX error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-24410
Description
When an attachment's name contains a control character, the XML is no longer valid when parsing the attachment's information from Microsoft via exchangelib.
Please note, when a new version of exchangelib is available, we will need to bump the docker image (should happen automatically, but we can revert this fix when it happens).
Details of the XML parsing issue can be found here - ecederstrand/exchangelib#1200
Does it break backward compatibility?