Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxiiFeed: fixed an issue where score was not handled properly #27213

Merged
merged 8 commits into from Jun 15, 2023

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Jun 5, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

fixed an issue where the score was not handled properly on "update custom fields" mode.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@moishce moishce marked this pull request as ready for review June 14, 2023 05:49
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
@moishce
Copy link
Contributor Author

moishce commented Jun 15, 2023

@yuvalbenshalom Need to force merge due to coverage drop.

@yuvalbenshalom yuvalbenshalom merged commit 4d2f0a5 into master Jun 15, 2023
18 of 19 checks passed
@yuvalbenshalom yuvalbenshalom deleted the taxiifeed_score branch June 15, 2023 08:29
TalNos pushed a commit that referenced this pull request Jun 16, 2023
* added score handling

* added rn

* added rn

* added rn

* update version

* Update Packs/FeedTAXII/ReleaseNotes/1_1_27.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

---------

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* added score handling

* added rn

* added rn

* added rn

* update version

* Update Packs/FeedTAXII/ReleaseNotes/1_1_27.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

---------

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants