Cisco ASA Enhancement #27240
Merged
Cisco ASA Enhancement #27240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
added
Community
Contribution Form Filled
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/qmasters-ltd_cisco-asa-enhancement
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @RotemAmit will know the proposed changes are ready to be reviewed. |
eyalpalo
requested changes
Jun 18, 2023
| if command == 'test-module': | ||
| return_results(test_command(client, isASAv)) | ||
| elif command in commands: | ||
| client.login(isASAv) |
There was a problem hiding this comment.
can you paste the error when the login method is called in the test_command and when it isn't (called in the main)?
eyalpalo
approved these changes
Jun 21, 2023
eyalpalo
merged commit a128ba4
into
demisto:contrib/qmasters-ltd_cisco-asa-enhancement
21 of 22 checks passed
eyalpalo
added a commit
that referenced
this pull request
Jun 25, 2023
* Cisco ASA Enhancement (#27240) * Added Updated readme * Changed mocked IPs to 1.1.1.1 to prevent secret validation failure * Added version of ASA in README * Added manual release notes * Updated releasenote to template prefixes * Updated currentVersion * Fixed type hint errors. * Removed unused import * Fixed type hint error * Made changes according to Eyal's CR. * Update docker image * Removed commented lines * Set default value 'True' for active in YML. * Added exception chaining as suggested. * Changed .format to f-string * Fixed unit-test for default value in active. * Cut down extra from pagination decorator * Update bracket indexing to get method for dictionaries * Fixed mypy type errors as a result of changing dictionary key indexing * Fixed outputs prefix * Added use-case for only inserting page_size in list command * Fixed bug in old function that may use in some cases `get` method on a list. * Updated docker image --------- Co-authored-by: LiorQM <lior.sb18@gmail.com> * tp * tp * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * doc review * doc review --------- Co-authored-by: LiorQM <106475467+LiorQM@users.noreply.github.com> Co-authored-by: LiorQM <lior.sb18@gmail.com> Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: epintzov <epintzov@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* Cisco ASA Enhancement (#27240) * Added Updated readme * Changed mocked IPs to 1.1.1.1 to prevent secret validation failure * Added version of ASA in README * Added manual release notes * Updated releasenote to template prefixes * Updated currentVersion * Fixed type hint errors. * Removed unused import * Fixed type hint error * Made changes according to Eyal's CR. * Update docker image * Removed commented lines * Set default value 'True' for active in YML. * Added exception chaining as suggested. * Changed .format to f-string * Fixed unit-test for default value in active. * Cut down extra from pagination decorator * Update bracket indexing to get method for dictionaries * Fixed mypy type errors as a result of changing dictionary key indexing * Fixed outputs prefix * Added use-case for only inserting page_size in list command * Fixed bug in old function that may use in some cases `get` method on a list. * Updated docker image --------- Co-authored-by: LiorQM <lior.sb18@gmail.com> * tp * tp * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * doc review * doc review --------- Co-authored-by: LiorQM <106475467+LiorQM@users.noreply.github.com> Co-authored-by: LiorQM <lior.sb18@gmail.com> Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: epintzov <epintzov@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* Cisco ASA Enhancement (demisto#27240) * Added Updated readme * Changed mocked IPs to 1.1.1.1 to prevent secret validation failure * Added version of ASA in README * Added manual release notes * Updated releasenote to template prefixes * Updated currentVersion * Fixed type hint errors. * Removed unused import * Fixed type hint error * Made changes according to Eyal's CR. * Update docker image * Removed commented lines * Set default value 'True' for active in YML. * Added exception chaining as suggested. * Changed .format to f-string * Fixed unit-test for default value in active. * Cut down extra from pagination decorator * Update bracket indexing to get method for dictionaries * Fixed mypy type errors as a result of changing dictionary key indexing * Fixed outputs prefix * Added use-case for only inserting page_size in list command * Fixed bug in old function that may use in some cases `get` method on a list. * Updated docker image --------- Co-authored-by: LiorQM <lior.sb18@gmail.com> * tp * tp * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * doc review * doc review --------- Co-authored-by: LiorQM <106475467+LiorQM@users.noreply.github.com> Co-authored-by: LiorQM <lior.sb18@gmail.com> Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: epintzov <epintzov@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have