Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Opensearch support for Elasticsearch feed #27333

Merged
merged 14 commits into from Jun 21, 2023
Merged

Added Opensearch support for Elasticsearch feed #27333

merged 14 commits into from Jun 21, 2023

Conversation

anilagr
Copy link
Contributor

@anilagr anilagr commented Jun 9, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added Opensearch support for Elasticsearch feed

Screenshots

ElasticSearchFeed_with_opensearch_option
indicator_index_in_opensearch
Fetched_indicator_from_opensearch
Opensearch_deployment_proof

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jun 9, 2023
@content-bot content-bot changed the base branch from master to contrib/anilagr_Opensearch_support_ES_Feed June 9, 2023 04:35
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @thefrieddan1 will know the proposed changes are ready to be reviewed.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Jun 9, 2023
@thefrieddan1
Copy link
Contributor

Hi @anilagr thank you for your contribution we appreciate your effort, I reviewed the content in the PR and would like to provide some feedback:

Please notice you need to update the integration version. In the pack_metadata.json file and add a release note for that version. You can use the demisto-sdk update-release-notes -i to help you with that.
Need to update the integration README file with the addition of the new argument.
You can use demisto-sdk generate-docs -i to help you with that.
As this is an XSOAR level support integration please add unit test with your added argument.
Thanks

@thefrieddan1 thefrieddan1 added the pending-contributor The PR is pending the response of its creator label Jun 11, 2023
@anilagr
Copy link
Contributor Author

anilagr commented Jun 14, 2023

It would be great to get some help for unit test.

@thefrieddan1
Copy link
Contributor

thefrieddan1 commented Jun 14, 2023 •
edited

Sure @anilagr np about the unit test.
I thought about perhaps running a unit test once with the ELASTIC_SEARCH_CLIENT as OpenSearch and once with the default.
Im currently checking about the command :
get-shared-indicators which was removed from the README but is not present in the yml file.

*Edit:
get-shared-indicators is to be removed. no need for it in the current integration.

dorschw
dorschw requested changes Jun 14, 2023
View reviewed changes
poetry.lock Outdated Show resolved Hide resolved
@thefrieddan1 thefrieddan1 added pending-demo Demo pending and removed pending-contributor The PR is pending the response of its creator labels Jun 19, 2023
@thefrieddan1 thefrieddan1 added docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jun 19, 2023
@content-bot
Copy link
Collaborator

content-bot commented Jun 19, 2023 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5581414

dorschw
dorschw previously approved these changes Jun 19, 2023
View reviewed changes
@thefrieddan1 thefrieddan1 added post-demo and removed pending-demo Demo pending labels Jun 21, 2023
@thefrieddan1 thefrieddan1 removed the request for review from ilaner June 21, 2023 14:55
@thefrieddan1 thefrieddan1 merged commit 298565f into demisto:contrib/anilagr_Opensearch_support_ES_Feed Jun 21, 2023
10 of 13 checks passed
@content-bot content-bot mentioned this pull request Jun 21, 2023
Merged
11 tasks
thefrieddan1 added a commit that referenced this pull request Jun 25, 2023
@content-bot @anilagr @thefrieddan1
Added Opensearch support for Elasticsearch feed (#27623)
369f0c2 
* Added Opensearch support for Elasticsearch feed (#27333)

* Added Opensearch support for Elasticsearch feed

* Updated release notes and readme

* Updated release notes and readme

* Revert changes to poetry lock

* Update docker image.
Remove tested on version x.x in README.

* Fix flake8 errors.

* Update docker comment in RN.

* Trying to add opensearchpy dependency for test

* fix flake8 errors.

* Adding known_words section

* Moving opensearch-py to dev-packages section.

* Update docker image

* Align yml docker with RN docker.

---------

Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>

* Updating docker image.

---------

Co-authored-by: anilagr <40182783+anilagr@users.noreply.github.com>
Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
@content-bot @anilagr
@thefrieddan1 @MosheEichler
Added Opensearch support for Elasticsearch feed (#27623)
7bb0d68 
* Added Opensearch support for Elasticsearch feed (#27333)

* Added Opensearch support for Elasticsearch feed

* Updated release notes and readme

* Updated release notes and readme

* Revert changes to poetry lock

* Update docker image.
Remove tested on version x.x in README.

* Fix flake8 errors.

* Update docker comment in RN.

* Trying to add opensearchpy dependency for test

* fix flake8 errors.

* Adding known_words section

* Moving opensearch-py to dev-packages section.

* Update docker image

* Align yml docker with RN docker.

---------

Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>

* Updating docker image.

---------

Co-authored-by: anilagr <40182783+anilagr@users.noreply.github.com>
Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
@content-bot @anilagr
@thefrieddan1 @xsoar-bot
Added Opensearch support for Elasticsearch feed (demisto#27623)
cc7400d 
* Added Opensearch support for Elasticsearch feed (demisto#27333)

* Added Opensearch support for Elasticsearch feed

* Updated release notes and readme

* Updated release notes and readme

* Revert changes to poetry lock

* Update docker image.
Remove tested on version x.x in README.

* Fix flake8 errors.

* Update docker comment in RN.

* Trying to add opensearchpy dependency for test

* fix flake8 errors.

* Adding known_words section

* Moving opensearch-py to dev-packages section.

* Update docker image

* Align yml docker with RN docker.

---------

Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>

* Updating docker image.

---------

Co-authored-by: anilagr <40182783+anilagr@users.noreply.github.com>
Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefrieddan1 thefrieddan1 thefrieddan1 approved these changes

@dorschw dorschw dorschw left review comments

Assignees

@thefrieddan1 thefrieddan1

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
4 participants
@anilagr @content-bot @thefrieddan1 @dorschw