Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Credentials part 4 (JavaScript) #27372

Merged
merged 15 commits into from Jun 15, 2023
Merged

Align Credentials part 4 (JavaScript) #27372

merged 15 commits into from Jun 15, 2023

Conversation

jlevypaloalto
Copy link
Contributor

@jlevypaloalto jlevypaloalto commented Jun 11, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: Align Credentials for CiscoSpark, RSANetWitnessPacketsAndLogs, Giphy, PacketMail, CiscoCloudLock

Description

Aligns creds for:

  • CiscoSpark
  • RSANetWitnessPacketsAndLogs
  • Giphy
  • PacketMail
  • CiscoCloudLock

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@dantavori
Copy link
Contributor

force merging due to missing test validations failing for JS integrations without instance.

@dantavori dantavori merged commit 7455ca5 into master Jun 15, 2023
11 of 15 checks passed
@dantavori dantavori deleted the jl-align-creds-4-js branch June 15, 2023 14:08
TalNos pushed a commit that referenced this pull request Jun 16, 2023
* CiscoSpark complete

* RSANetWitnessPacketsAndLogs complete

* Giphy complete

* PacketMail complete

* CiscoCloudLock complete

* Update .pack-ignore

* Update .pack-ignore 2

* Update .pack-ignore 3

* Update .pack-ignore 4

* username_creds -> user_creds

* modified code

* update docker

* prioritized creds

* added readme to giphy

* removed error codes
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* CiscoSpark complete

* RSANetWitnessPacketsAndLogs complete

* Giphy complete

* PacketMail complete

* CiscoCloudLock complete

* Update .pack-ignore

* Update .pack-ignore 2

* Update .pack-ignore 3

* Update .pack-ignore 4

* username_creds -> user_creds

* modified code

* update docker

* prioritized creds

* added readme to giphy

* removed error codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants