Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XSOAR CI/CD] New playbook - Delete Custom Content #27385

Merged
merged 18 commits into from Jun 15, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Jun 12, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Add new playbook - Delete Custom Content.
Add new script - GetIdsFromCustomContent

@mmhw mmhw changed the title New playbook - Delete Custom Content [XSOAR CI/CD] New playbook - Delete Custom Content Jun 12, 2023
@mmhw mmhw self-assigned this Jun 12, 2023
@mmhw mmhw requested a review from DinaMeylakh June 12, 2023 12:57
id: fab4e101-1e2b-45b0-847e-e69efca67d62
version: -1
name: Download custom content
description: Download files from Core server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Download files from Core server
description: Download files from the Core server.

id: e20d6675-4dc5-4b6b-842b-4db3257ccfeb
version: -1
name: GetIdsFromCustomContent
description: Extract custom content ids from custom content bundle file and exclude ids as specified.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Extract custom content ids from custom content bundle file and exclude ids as specified.
description: Extract custom content IDs from custom content bundle file and exclude IDs as specified.

id: b376e0ed-14a7-4a90-8e29-ec279cd50067
version: -1
name: Delete Content
description: Delete content to keep XSOAR tidy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Delete content to keep XSOAR tidy.
description: Delete content to keep Cortex XSOAR tidy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShirleyDenkberg
Delete content to be able to install them via the CI/CD process.

id: 1e75bc98-ff87-4cf7-856c-b3d7f5b670c5
version: -1
name: Print Status
description: Prints text to war room (Markdown supported)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Prints text to war room (Markdown supported)
description: Prints text to War Room (Markdown supported)

id: 9b1ed2f4-0c81-4675-8f22-1bb51118e29e
version: -1
name: Print Deletion Error
description: Prints an error entry with a given message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Prints an error entry with a given message
description: Prints an error entry with a given message.

@ShirleyDenkberg
Copy link
Contributor

@bziser @ShahafBenYakir @DinaMeylakh Doc review completed.

mmhw and others added 7 commits June 12, 2023 16:34
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, initial CR :)

Copy link
Contributor

@bziser bziser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add return types to all the functions

@mmhw mmhw merged commit 47842a2 into master Jun 15, 2023
14 of 15 checks passed
@mmhw mmhw deleted the MW/CIAC-6702/New_playbook_to_delete_custom_items branch June 15, 2023 09:19
TalNos pushed a commit that referenced this pull request Jun 16, 2023
* New playbook - Delete Custom Content

* Update the RN; Fix the unit tests

* Update the docker image; Add playbook image

* Apply suggestions from code review

* Added return types
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* New playbook - Delete Custom Content

* Update the RN; Fix the unit tests

* Update the docker image; Add playbook image

* Apply suggestions from code review

* Added return types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants