Align credentials stores part 19 #27463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
credentials don't work for WhatIsMyBrowser link for open issue therefore, the build fails. |
maimorag
requested review from
Shellyber
and removed request for
ostolero and
JudahSchwartz
Shellyber
reviewed
Jun 18, 2023
|
@maimorag API key seems to be updated. Please check if it works and remove the test from skipped. The build should pass afterward. |
|
@maimorag What's the status here? |
Shellyber
reviewed
Jun 22, 2023
Packs/WhatIsMyBrowser/Integrations/WhatIsMyBrowser/WhatIsMyBrowser.py
Outdated
Show resolved
Hide resolved
Shellyber
approved these changes
Jun 22, 2023
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* Align credentials stores part 19 * fix * unremoving * remove * remove from conf json * try * change * execpetion
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* Align credentials stores part 19 * fix * unremoving * remove * remove from conf json * try * change * execpetion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
Relates: link to the issue
Description
Change the type of credentials, from type 4 to type 9.
Minimum version of Cortex XSOAR
Does it break backward compatibility?