Phishing Campaign - GetCampaignIncidentsInfo handling deleted incidents #27621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorschw
reviewed
Jun 22, 2023
Packs/Campaign/Scripts/GetCampaignIncidentsInfo/GetCampaignIncidentsInfo.py
Outdated
Show resolved
Hide resolved
Packs/Campaign/Scripts/GetCampaignIncidentsInfo/GetCampaignIncidentsInfo.py
Outdated
Show resolved
Hide resolved
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
…identsInfo.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
dorschw
reviewed
Jun 22, 2023
Packs/Campaign/Scripts/GetCampaignIncidentsInfo/GetCampaignIncidentsInfo.py
Outdated
Show resolved
Hide resolved
Packs/Campaign/Scripts/GetCampaignIncidentsInfo/GetCampaignIncidentsInfo.py
Outdated
Show resolved
Hide resolved
… phishing_campaign_incident
… phishing_campaign_incident
dorschw
approved these changes
Jun 22, 2023
Comment on lines
135
to
+137
| try: | ||
| main() | ||
| assert False, 'SystemExit should occurred' | ||
| pytest.fail(msg='SystemExit should occurred') |
There was a problem hiding this comment.
If you feel like being a good scout, let's change this to with pytest.raises(SystemExit): main(), it's the same but more explicit. Not urgent anyway.
|
|
||
| ##### GetCampaignIncidentsInfo | ||
|
|
||
| - Fixed an issue causing the script to fail when incidents were deleted. |
There was a problem hiding this comment.
Suggested change
| - Fixed an issue causing the script to fail when incidents were deleted. | |
| - Fixed an issue causing the script to fail after incidents are deleted. |
There was a problem hiding this comment.
@ShirleyDenkberg Which of the options do you think is clearer?
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
…ts (#27621) * remove deleted incident * RN * DO * Update Packs/Campaign/ReleaseNotes/3_2_24.md Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Update Packs/Campaign/Scripts/GetCampaignIncidentsInfo/GetCampaignIncidentsInfo.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * safe access * Bump pack from version Campaign to 3.3.1. * fix CR * add UT * fix pre-commit * fix UT * fix PT015 * add import --------- Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
…ts (demisto#27621) * remove deleted incident * RN * DO * Update Packs/Campaign/ReleaseNotes/3_2_24.md Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Update Packs/Campaign/Scripts/GetCampaignIncidentsInfo/GetCampaignIncidentsInfo.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * safe access * Bump pack from version Campaign to 3.3.1. * fix CR * add UT * fix pre-commit * fix UT * fix PT015 * add import --------- Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have