Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported to take single value as an array having the value. #27646

Merged
merged 25 commits into from Jun 27, 2023
Merged

Conversation

spearmin10
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

Currently it doesn't work when putting a non-list value.
This allows it to support to put non-list value as an array.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jun 22, 2023
@content-bot content-bot changed the base branch from master to contrib/spearmin10_MakePair June 22, 2023 07:11
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @RotemAmit will know the proposed changes are ready to be reviewed.

Copy link
Contributor

@RotemAmit RotemAmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! Nice work!
Can you send me a video showing your changes, so that I will see that everything is working as expected?

@spearmin10
Copy link
Contributor Author

@RotemAmit
Thank you for your review. Here is the video for demo.

Video Passcode: !.j%1rdXEC

@ShirleyDenkberg ShirleyDenkberg self-assigned this Jun 27, 2023
@ShirleyDenkberg
Copy link
Contributor

@RotemAmit Doc review completed.

@spearmin10 spearmin10 requested a review from ilappe as a code owner June 27, 2023 12:43
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023

CLA assistant check
All committers have signed the CLA.

@RotemAmit RotemAmit added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jun 27, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5628082

@RotemAmit RotemAmit merged commit 30114af into demisto:contrib/spearmin10_MakePair Jun 27, 2023
19 of 21 checks passed
RotemAmit pushed a commit that referenced this pull request Jun 28, 2023
…#27772)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Supported to take single value as an array having the value.

* Supported to take single value as an array having the value.

* Update docker image

* Update pack_metadata

* Update RN

---------

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com>
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
…#27772)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Supported to take single value as an array having the value.

* Supported to take single value as an array having the value.

* Update docker image

* Update pack_metadata

* Update RN

---------

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com>
@spearmin10 spearmin10 deleted the MakePair branch July 4, 2023 05:03
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
…#27646) (demisto#27772)

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Update .devcontainer.json name

* Supported to take single value as an array having the value.

* Supported to take single value as an array having the value.

* Update docker image

* Update pack_metadata

* Update RN

---------

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
5 participants