Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft support of national clouds - Microsoft Defender for Cloud Apps #27705

Merged
merged 45 commits into from Aug 9, 2023

Conversation

kobymeir
Copy link
Contributor

@kobymeir kobymeir commented Jun 26, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6390
docs: demisto/content-docs#1359

Description

Microsoft Defender for Applications (MCAS/MDA) - GCC Support

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@kobymeir kobymeir self-assigned this Jun 26, 2023
@kobymeir kobymeir force-pushed the microsoft-usgov-support-mcas branch from b990f42 to d529687 Compare June 26, 2023 05:29
@kobymeir kobymeir marked this pull request as ready for review June 26, 2023 10:26
@kobymeir kobymeir changed the title Microsoft usgov support mcas Microsoft Defender for Applications (MCAS/MDA) - GCC Support Jun 26, 2023
@kobymeir kobymeir changed the title Microsoft Defender for Applications (MCAS/MDA) - GCC Support Microsoft support of national clouds - Microsoft Defender for Cloud Apps Jun 27, 2023
Copy link
Contributor

@michal-dagan michal-dagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Why do we not support the Custom option?

@kobymeir kobymeir force-pushed the microsoft-usgov-support-mcas branch from 92bc411 to 7ced59a Compare July 6, 2023 04:43
Copy link
Contributor

@michal-dagan michal-dagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rn contains an update of Docker that does not appear on the yml files

@michal-dagan
Copy link
Contributor

Great!

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • MicrosoftGraphSecurity pack version was bumped to 2.1.27.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@kobymeir
Copy link
Contributor Author

kobymeir commented Aug 9, 2023

Force merge is due to a bug in update-release notes, which doesn't update the docker images.

@yuvalbenshalom yuvalbenshalom merged commit 8804a71 into master Aug 9, 2023
14 of 16 checks passed
@yuvalbenshalom yuvalbenshalom deleted the microsoft-usgov-support-mcas branch August 9, 2023 15:06
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
…pps (demisto#27705)

* CIAC-3854 [Email Communication] Add "Create_Incidents" parameter and improve email identifier

* gcc support

* gcc support

* fix ruff

* fix ruff

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com>

* Nightly build XSIAM - search & install packs retry mechanism is broken.

fixing pathlib ruff issues.

* mcas - ut and code convention

* CIAC-6390 Microsoft Defender for Applications (MCAS/MDA)
fix UT

* CIAC-6390 Microsoft Defender for Applications (MCAS/MDA)
fix UT

* mcas

* lint fixes

* adding azure cloud

* adding azure cloud

* sourcery

* sourcery

* sourcery

* sourcery

* sourcery

* pr review

* pr review

* pr review

* merge conflicts

* merge conflicts

* doc review

* Adding support for Microsoft Defender for APi Endpoints in the Microsoft API Module.

* Adding support for Microsoft Defender for APi Endpoints in the Microsoft API Module.

* fix to api module

* Added support for Microsoft Defender for Application Endpoints in the Microsoft API Module.

* Added support for Microsoft Defender for Application Endpoints in the Microsoft API Module.

* Added support for Microsoft Defender for Application Endpoints in the Microsoft API Module.

* fixing UT

* fixing TPB

* fixing code review issues

* fixing code review issues

* fixing RN issue

* Bump pack from version MicrosoftGraphSecurity to 2.1.27.

---------

Co-authored-by: kobymeir <ymeir@paloaltonetworks.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants