FireEyeHX Create Indicator Enhacement #27717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added additional arguments for fireeye-hx-create-indicator command. Updated FireEyeHXv2.py to use additional arguments in the HTTP POST. * Added 2_3_9.md release note and bumped up version in pack_metadata.json * Updated release notes * Updated release notes and README.md * Updated FireEyeHXv2.py * Updated Docker Image in FireEyeHXv2.yml Updated Release Notes 2_3_9.md * Adding unit test for new optional arguments in create_indicator_command * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
content-bot
added
Contribution
|
@thefrieddan1 Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
thefrieddan1
approved these changes
Jun 28, 2023
thefrieddan1
deleted the
contrib/xsoar-contrib_contrib-mohlcyber-FireEyeHX
branch
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* FireEyeHX Create Indicator Enhacement (#27625) * Added additional arguments for fireeye-hx-create-indicator command. Updated FireEyeHXv2.py to use additional arguments in the HTTP POST. * Added 2_3_9.md release note and bumped up version in pack_metadata.json * Updated release notes * Updated release notes and README.md * Updated FireEyeHXv2.py * Updated Docker Image in FireEyeHXv2.yml Updated Release Notes 2_3_9.md * Adding unit test for new optional arguments in create_indicator_command * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Martin Ohl <Martin.Ohl@ohl-net.eu> Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* FireEyeHX Create Indicator Enhacement (demisto#27625) * Added additional arguments for fireeye-hx-create-indicator command. Updated FireEyeHXv2.py to use additional arguments in the HTTP POST. * Added 2_3_9.md release note and bumped up version in pack_metadata.json * Updated release notes * Updated release notes and README.md * Updated FireEyeHXv2.py * Updated Docker Image in FireEyeHXv2.yml Updated Release Notes 2_3_9.md * Adding unit test for new optional arguments in create_indicator_command * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Martin Ohl <Martin.Ohl@ohl-net.eu> Co-authored-by: Danny_Fried <dfried@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@mohlcyber
Status
Description
Updated the fireeye-hx-create-indicator command to support additional optional arguments.
This includes - display_name, description and platforms
Does it break backward compatibility?
Must have