Jira V3 - Added missing assert to unit tests #27738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ira-missing-assert-unit-tests
dorschw
approved these changes
Jun 26, 2023
| return json.loads(f.read()) | ||
|
|
||
|
|
||
| def util_load_bytes_file(path: str): | ||
| with io.open(path, mode='rb') as f: | ||
| with open(path, mode='rb') as f: |
There was a problem hiding this comment.
the best practice here would be return Path(path).read_bytes(), but maybe not in this PR.
There was a problem hiding this comment.
Can such a suggestion be added using ruff in the pre-commit command?
There was a problem hiding this comment.
Yes. For this to happen:
- Add this test to
flake8-use-pathlib(hope they approve it), let them assign some error code - Use the same error code to suggest this change to Ruff
MosheEichler
pushed a commit
that referenced
this pull request
Jul 2, 2023
* Added missing assert to unit tests, and fixed a unit test * Made changes suggested by ruff
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* Added missing assert to unit tests, and fixed a unit test * Made changes suggested by ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Added missing assert to unit tests, and fixed a unit test.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have