Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing 2 widgets from the library #27747

Merged
merged 11 commits into from Jun 28, 2023
Merged

Removing 2 widgets from the library #27747

merged 11 commits into from Jun 28, 2023

Conversation

rshunim
Copy link
Contributor

@rshunim rshunim commented Jun 27, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

related: link to the issue

Description

Deleted two packs in this PR, but need to delete widgets (json files) so they don't show up in the dashboard editor.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@rshunim rshunim requested a review from dorschw June 27, 2023 06:59
@rshunim rshunim self-assigned this Jun 27, 2023
@rshunim
Copy link
Contributor Author

rshunim commented Jun 27, 2023

ForceMerge is needed since we're removing two deprecated widgets
(so they don't show up in the dashboard editor)

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
@yuvalbenshalom yuvalbenshalom merged commit 49719cd into master Jun 28, 2023
10 of 14 checks passed
@yuvalbenshalom yuvalbenshalom deleted the remove_widgets branch June 28, 2023 11:53
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* remove 2 widgets from the library

* RN

* meta data

* fix pre commit

* RN

* Update Packs/CommonWidgets/ReleaseNotes/1_2_24.md

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* remove 2 widgets from the library

* RN

* meta data

* fix pre commit

* RN

* Update Packs/CommonWidgets/ReleaseNotes/1_2_24.md

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants