Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email regex doesnt catch email with a hyphen in the sub-domain correctly #27801

Merged
merged 6 commits into from Jun 29, 2023

Conversation

Ni-Knight
Copy link
Contributor

@Ni-Knight Ni-Knight commented Jun 29, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-25747

Description

Fixed an issue where the email was caught incorrectly due to a hyphen in the sub domain of the email domain part.

Email extraction PB was also updated to test such cases:
image

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@Ni-Knight Ni-Knight requested review from DeanArbel and removed request for michalgold and idovandijk June 29, 2023 08:05
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonTypes pack version was bumped to 3.3.79.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@Ni-Knight Ni-Knight merged commit 2666652 into master Jun 29, 2023
14 checks passed
@Ni-Knight Ni-Knight deleted the dra-email-regex-fix branch June 29, 2023 11:06
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
…tly (demisto#27801)

* Adding hyphen to long domain in emails

* RN

* Updated test playbook with a hyphen domain in email

* fixed pb step title

* Bump pack from version CommonTypes to 3.3.79.

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants