Use string split and validations #27851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on advanced filters.
Bump version. Update RN.
|
@thefrieddan1 Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
DeanArbel
approved these changes
Sep 4, 2023
moishce
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Use string split and validations on advanced filters. * Add hints add docstrings * Update docker image. Bump version. Update RN. * flake8 errors. * Update Packs/AWS-SecurityHub/ReleaseNotes/1_3_5.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Resolve conflicts. Bump version. * Remove TODO. * Version bump. * Minor changes * change RN. * tech doc review changes. * flake8 errors --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Oct 5, 2023
* Use string split and validations on advanced filters. * Add hints add docstrings * Update docker image. Bump version. Update RN. * flake8 errors. * Update Packs/AWS-SecurityHub/ReleaseNotes/1_3_5.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Resolve conflicts. Bump version. * Remove TODO. * Version bump. * Minor changes * change RN. * tech doc review changes. * flake8 errors --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* Use string split and validations on advanced filters. * Add hints add docstrings * Update docker image. Bump version. Update RN. * flake8 errors. * Update Packs/AWS-SecurityHub/ReleaseNotes/1_3_5.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Resolve conflicts. Bump version. * Remove TODO. * Version bump. * Minor changes * change RN. * tech doc review changes. * flake8 errors --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on advanced filters.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Advanced filters regex did not work for customer. Changed the logic to use str split. Tested on example from customer.