FeedTAXII2: return report object with the relationships #27860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ni-Knight
reviewed
Jul 3, 2023
| name='related-to', | ||
| entity_a=report_obj.get('name'), | ||
| entity_a_type='Report', | ||
| entity_b=relation_type_and_id[1], |
There was a problem hiding this comment.
We can't relate to a hash, its an invalid value for all types. We have to search the actual STIX envelope for the object.
Ni-Knight
approved these changes
Jul 3, 2023
…pe/XSUP-25648/return_report_with_relationships
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jul 26, 2023
* retrun report with relationships * remove the sub reporct condition * add correct relationship * CR changes * test + changes * update RN * fix linter * Update Packs/FeedTAXII/ReleaseNotes/1_1_28.md Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com> * fix RN * fix test * fix RN --------- Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-25648
Description
Return the report object with it's relationships.