Fix fetch bug EWS V2 #27880
Merged
Fix fetch bug EWS V2 #27880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JudahSchwartz
approved these changes
Jul 11, 2023
amshamah419
reviewed
Jul 11, 2023
Comment on lines
-350
to
-360
| for key, protocol in key_protocols: | ||
| try: | ||
| if "thread_pool" in protocol.__dict__: | ||
| demisto.debug('terminating thread pool key{} id: {}'.format(key, id(protocol.thread_pool))) | ||
| protocol.thread_pool.terminate() | ||
| del protocol.__dict__["thread_pool"] | ||
| else: | ||
| demisto.info( | ||
| 'Thread pool not found (ignoring terminate) in protcol dict: {}'.format(dir(protocol.__dict__))) | ||
| except Exception as ex: | ||
| demisto.error("Error with thread_pool.terminate, ignoring: {}".format(ex)) |
There was a problem hiding this comment.
Why is this being removed?
There was a problem hiding this comment.
this is the famous error print thats been printed everywhere in the last year+ without having an affect
Every time this runs it fails on a type error, so it never actually can do anything
Its also redundant, the point here seems that we didnt trust shut down to do its job for some reason and we are manually trying to do this here (without success not that anybody has noticed)
Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Fix an error where some fields are returned as list and raised an error
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have