New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the lookback #27901
Merged
Merged
Enhance the lookback #27901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
ilaner
requested review from
yaakovpraisler
and removed request for
daryakoval and
yucohen
July 6, 2023 10:10
yaakovpraisler
approved these changes
Jul 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just a minor comment -
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
…into enhance_lookback
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* falcon try * remove offset * delete offset * fetch limit * fix CS * update * update * use DATE_FORMAT * update pack metadata * debug logs * fix condition * CSP * Update Packs/CrowdStrikeFalcon/ReleaseNotes/1_11_0.md Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> * restore remove incident ids * Bump pack from version CrowdStrikeFalcon to 1.11.0. * remove incident ids all the time * fixes * current time * CSP * fid * fix * fix LB if we stuck * CSP push * push * save limit in variable * remove file * fix tests * update * fix * RN * fixes * Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * fixes * Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * fixes * fixes --------- Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: YuvHayun <yhayun011@gmail.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* falcon try * remove offset * delete offset * fetch limit * fix CS * update * update * use DATE_FORMAT * update pack metadata * debug logs * fix condition * CSP * Update Packs/CrowdStrikeFalcon/ReleaseNotes/1_11_0.md Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> * restore remove incident ids * Bump pack from version CrowdStrikeFalcon to 1.11.0. * remove incident ids all the time * fixes * current time * CSP * fid * fix * fix LB if we stuck * CSP push * push * save limit in variable * remove file * fix tests * update * fix * RN * fixes * Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * fixes * Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> * fixes * fixes --------- Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: YuvHayun <yhayun011@gmail.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-24966?filter=-1
Description
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have