Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the lookback #27901

Merged
merged 47 commits into from Jul 10, 2023
Merged

Enhance the lookback #27901

merged 47 commits into from Jul 10, 2023

Conversation

ilaner
Copy link
Contributor

@ilaner ilaner commented Jul 4, 2023

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-24966?filter=-1

Description

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@ilaner ilaner requested review from yaakovpraisler and removed request for daryakoval and yucohen July 6, 2023 10:10
Copy link
Contributor

@yaakovpraisler yaakovpraisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just a minor comment -

YuvHayun and others added 7 commits July 9, 2023 12:26
@YuvHayun YuvHayun merged commit 23fb20a into master Jul 10, 2023
15 of 16 checks passed
@YuvHayun YuvHayun deleted the enhance_lookback branch July 10, 2023 17:10
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* falcon try

* remove offset

* delete offset

* fetch limit

* fix CS

* update

* update

* use DATE_FORMAT

* update pack metadata

* debug logs

* fix condition

* CSP

* Update Packs/CrowdStrikeFalcon/ReleaseNotes/1_11_0.md

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* restore remove incident ids

* Bump pack from version CrowdStrikeFalcon to 1.11.0.

* remove incident ids all the time

* fixes

* current time

* CSP

* fid

* fix

* fix LB if we stuck

* CSP push

* push

* save limit in variable

* remove file

* fix tests

* update

* fix

* RN

* fixes

* Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py

Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>

* fixes

* Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py

Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>

* fixes

* fixes

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: YuvHayun <yhayun011@gmail.com>
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* falcon try

* remove offset

* delete offset

* fetch limit

* fix CS

* update

* update

* use DATE_FORMAT

* update pack metadata

* debug logs

* fix condition

* CSP

* Update Packs/CrowdStrikeFalcon/ReleaseNotes/1_11_0.md

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* restore remove incident ids

* Bump pack from version CrowdStrikeFalcon to 1.11.0.

* remove incident ids all the time

* fixes

* current time

* CSP

* fid

* fix

* fix LB if we stuck

* CSP push

* push

* save limit in variable

* remove file

* fix tests

* update

* fix

* RN

* fixes

* Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py

Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>

* fixes

* Update Packs/Base/Scripts/CommonServerPython/CommonServerPython.py

Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>

* fixes

* fixes

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: YuvHayun <yhayun011@gmail.com>
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants