Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SentinelOne Bug fixes #27909

Merged
merged 5 commits into from Jul 11, 2023
Merged

SentinelOne Bug fixes #27909

merged 5 commits into from Jul 11, 2023

Conversation

munna-metron
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Partner Support Level Indicates that the contribution is for Partner supported pack labels Jul 4, 2023
@content-bot content-bot changed the base branch from master to contrib/metron-labs_SentinelOneV3.2.1_new_fixes July 4, 2023 11:55
@content-bot content-bot requested a review from maimorag July 4, 2023 11:56
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @maimorag will know the proposed changes are ready to be reviewed.

@kgal-pan kgal-pan self-assigned this Jul 4, 2023
@maimorag
Copy link
Contributor

maimorag commented Jul 4, 2023

Hi @munna-metron ,
Thank you for your contribution!
Please sign the CLA and Contribution Registration form so I can start the review :)

@munna-metron
Copy link
Contributor Author

Hi @munna-metron , Thank you for your contribution! Please sign the CLA and Contribution Registration form so I can start the review :)

HI @maimorag, i do filled the contribution form but its not reflecting here

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Jul 5, 2023
@kgal-pan
Copy link
Contributor

kgal-pan commented Jul 5, 2023

Hi @munna-metron , Thank you for your contribution! Please sign the CLA and Contribution Registration form so I can start the review :)

HI @maimorag, i do filled the contribution form but its not reflecting here

Should be good now.

@maimorag maimorag requested a review from efelmandar July 5, 2023 12:56
maimorag
maimorag reviewed Jul 5, 2023
View reviewed changes
Copy link
Contributor

@maimorag maimorag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @munna-metron ,
Thank you for your contribution!
Good work :)
I recommend running pre-commit, for more explanation click here

@munna-metron
Copy link
Contributor Author

Hi @munna-metron , Thank you for your contribution! Good work :) I recommend running pre-commit, for more explanation click here

Done :)

@dorschw dorschw added the pending-contributor The PR is pending the response of its creator label Jul 10, 2023
@efelmandar
Copy link
Contributor

@maimorag Finished my review, I approve the changes.

@munna-metron Thank you again for your contribution it is highly appreciated!

@maimorag maimorag added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 11, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5738432

@maimorag maimorag merged commit fe4dd81 into demisto:contrib/metron-labs_SentinelOneV3.2.1_new_fixes Jul 11, 2023
22 of 23 checks passed
@content-bot content-bot mentioned this pull request Jul 11, 2023
Merged
11 tasks
maimorag added a commit that referenced this pull request Jul 12, 2023
@content-bot @munna-metron @maimorag
SentinelOne Bug fixes (#27909) (#28072)
c1dba40 
* FIxes of some of the issues reported

* bumped the version to the 3.2.2

* mentioned the new arguments those are incuded for run remote script command

* executed the pre-commit on the sentinelone

Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
@content-bot @munna-metron
@maimorag @xsoar-bot
SentinelOne Bug fixes (demisto#27909) (demisto#28072)
185bdd3 
* FIxes of some of the issues reported

* bumped the version to the 3.2.2

* mentioned the new arguments those are incuded for run remote script command

* executed the pre-commit on the sentinelone

Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
@content-bot @munna-metron
@maimorag @xsoar-bot
SentinelOne Bug fixes (demisto#27909) (demisto#28072)
7377e03 
* FIxes of some of the issues reported

* bumped the version to the 3.2.2

* mentioned the new arguments those are incuded for run remote script command

* executed the pre-commit on the sentinelone

Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com>
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgal-pan kgal-pan kgal-pan left review comments

@maimorag maimorag maimorag approved these changes

@efelmandar efelmandar Awaiting requested review from efelmandar

Assignees

@maimorag maimorag

@kgal-pan kgal-pan

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! Partner Support Level Indicates that the contribution is for Partner supported pack Partner pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
6 participants
@munna-metron @content-bot @maimorag @kgal-pan @efelmandar @dorschw