Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw_result to IPNetwork #27913

Merged

Conversation

martinspielmann
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

This contribution improves the existing IPNetwork automation. In the current implementation, it is hardly usable within other automations, because it does not return a raw_result. Instead, it only extends the Context. This is OK for playbooks, but not for automations as execute_command will always be empty.

With the provided change, a proper CommandResult will be returned by the automation, so that it works perfectly fine when used within another automation using execute_command. Change is 100% backward compatible.
Also, using return_results instead of deprecated return_outputs

Minimum version of Cortex XSOAR

  • 6.0.0

Does it break backward compatibility?

  • Yes
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Community Contribution Form Filled Whether contribution form filled or not. labels Jul 4, 2023
@content-bot content-bot changed the base branch from master to contrib/martinspielmann_master July 4, 2023 13:11
@content-bot content-bot requested a review from maimorag July 4, 2023 13:12
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @maimorag will know the proposed changes are ready to be reviewed.

Copy link
Contributor

@maimorag maimorag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martinspielmann,
Thank you for your contribution!
Good work!
Please see my note and feel free to reach out to me with any questions- I'm available here or on Slack :)

@dorschw dorschw added the pending-contributor The PR is pending the response of its creator label Jul 10, 2023
@maimorag
Copy link
Contributor

Good job :)
Please bump the pack version in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run the demisto-sdk update-release-notes command - for more information please see: https://xsoar.pan.dev/docs/concepts/demisto-sdk#update-release-notes.

@maimorag maimorag merged commit fd107a3 into demisto:contrib/martinspielmann_master Jul 25, 2023
16 of 19 checks passed
@content-bot content-bot mentioned this pull request Jul 25, 2023
8 tasks
maimorag added a commit that referenced this pull request Jul 25, 2023
* Add raw_result to IPNetwork

* change the type hints in the function return type to CommandResults as well

* Update Packs/CommonScripts/Scripts/IPNetwork/IPNetwork.py



* adding RL

* removing typing.Tuple

* docker update

---------

Co-authored-by: Martin <mail@martinspielmann.de>
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
Co-authored-by: maimorag <mmorag@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Add raw_result to IPNetwork

* change the type hints in the function return type to CommandResults as well

* Update Packs/CommonScripts/Scripts/IPNetwork/IPNetwork.py



* adding RL

* removing typing.Tuple

* docker update

---------

Co-authored-by: Martin <mail@martinspielmann.de>
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
Co-authored-by: maimorag <mmorag@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Add raw_result to IPNetwork

* change the type hints in the function return type to CommandResults as well

* Update Packs/CommonScripts/Scripts/IPNetwork/IPNetwork.py



* adding RL

* removing typing.Tuple

* docker update

---------

Co-authored-by: Martin <mail@martinspielmann.de>
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
Co-authored-by: maimorag <mmorag@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! pending-contributor The PR is pending the response of its creator stale-branch Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
4 participants