New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raw_result to IPNetwork #27913
Add raw_result to IPNetwork #27913
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @maimorag will know the proposed changes are ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @martinspielmann,
Thank you for your contribution!
Good work!
Please see my note and feel free to reach out to me with any questions- I'm available here or on Slack :)
Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com>
Good job :) |
fd107a3
into
demisto:contrib/martinspielmann_master
* Add raw_result to IPNetwork * change the type hints in the function return type to CommandResults as well * Update Packs/CommonScripts/Scripts/IPNetwork/IPNetwork.py * adding RL * removing typing.Tuple * docker update --------- Co-authored-by: Martin <mail@martinspielmann.de> Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com> Co-authored-by: maimorag <mmorag@paloaltonetworks.com>
* Add raw_result to IPNetwork * change the type hints in the function return type to CommandResults as well * Update Packs/CommonScripts/Scripts/IPNetwork/IPNetwork.py * adding RL * removing typing.Tuple * docker update --------- Co-authored-by: Martin <mail@martinspielmann.de> Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com> Co-authored-by: maimorag <mmorag@paloaltonetworks.com>
* Add raw_result to IPNetwork * change the type hints in the function return type to CommandResults as well * Update Packs/CommonScripts/Scripts/IPNetwork/IPNetwork.py * adding RL * removing typing.Tuple * docker update --------- Co-authored-by: Martin <mail@martinspielmann.de> Co-authored-by: Mai Morag <81917647+maimorag@users.noreply.github.com> Co-authored-by: maimorag <mmorag@paloaltonetworks.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Description
This contribution improves the existing IPNetwork automation. In the current implementation, it is hardly usable within other automations, because it does not return a raw_result. Instead, it only extends the Context. This is OK for playbooks, but not for automations as
execute_command
will always be empty.With the provided change, a proper CommandResult will be returned by the automation, so that it works perfectly fine when used within another automation using
execute_command
. Change is 100% backward compatible.Also, using
return_results
instead of deprecatedreturn_outputs
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have