Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaspersky Security Center - add test pb to conf.json #27941

Merged
merged 4 commits into from Jul 5, 2023

Conversation

MLainer1
Copy link
Contributor

@MLainer1 MLainer1 commented Jul 5, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@MLainer1 MLainer1 marked this pull request as ready for review July 5, 2023 14:38
@MLainer1 MLainer1 requested a review from ostolero as a code owner July 5, 2023 14:38
@MLainer1 MLainer1 requested a review from yucohen July 5, 2023 14:39
Copy link
Contributor

@ostolero ostolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! let's try and add some change to the tpb file (a space in the description), so it's collected by the test collector and we can see it's successful.

@MLainer1 MLainer1 requested a review from dantavori July 5, 2023 15:19
@MLainer1
Copy link
Contributor Author

MLainer1 commented Jul 5, 2023

This pr needs force merce due to issue with the move to gcp - the build cannot connect to the instance. attaching a green run of the tpb from a self-service
Screenshot 2023-07-05 at 20 22 59

@dantavori dantavori merged commit 79458d9 into master Jul 5, 2023
15 of 16 checks passed
@dantavori dantavori deleted the Kaspersky_test_laybook_conf branch July 5, 2023 17:43
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Kaspersky Security Center - add test pb to conf.json

* fix flake8 and tests

* collect tpb

* di
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants