Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAN-OS] - pan-os-create-tag fails with error "set failed, may need to override template object first" #27943

Merged
merged 26 commits into from Jul 13, 2023

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Jul 5, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue
fixes: link to the issue

Description

  • Fixed an issue where the pan-os-create-tag command didn't work for Firewall instances.
    As a result of using the 'disable-override' argument when using Firewall instances, it is not supported
  • Added support for the pan-os-edit-rule command that allows tags to be removed even if rule tags' elements remain empty.

Screenshots

when using panorama API:
image
when using Pan-os API:
image

@michal-dagan michal-dagan marked this pull request as ready for review July 6, 2023 12:58
@michal-dagan michal-dagan requested a review from bziser July 6, 2023 12:58
@michal-dagan michal-dagan changed the title Ciac 7270 support f w tags [PAN-OS] - pan-os-create-tag fails with error "set failed, may need to override template object first" Jul 6, 2023
Copy link
Contributor

@GuyAfik GuyAfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please add a UT if possible

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • PAN-OS pack version was bumped to 1.17.14.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@michal-dagan michal-dagan requested a review from bziser July 11, 2023 09:11
@michal-dagan michal-dagan requested a review from bziser July 13, 2023 10:16
@ShirleyDenkberg
Copy link
Contributor

@bziser @GuyAfik Doc review completed.

@ShirleyDenkberg ShirleyDenkberg self-assigned this Jul 13, 2023
@michal-dagan michal-dagan merged commit 785b83c into master Jul 13, 2023
17 checks passed
@michal-dagan michal-dagan deleted the CIAC-7270-support-fW-tags branch July 13, 2023 13:27
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
…o override template object first" (demisto#27943)


* fixed the element

* pre-commit

* added support for removing the last tag
and added support for warnings when attempting to remove a non-existing value

---------

Co-authored-by: Content Bot <bot@demisto.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
…o override template object first" (demisto#27943)


* fixed the element

* pre-commit

* added support for removing the last tag
and added support for warnings when attempting to remove a non-existing value

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants