-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update incidentfields markdown format #27945
Update incidentfields markdown format #27945
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed. |
Hi @joe-cosgrove, Please bump the version of the pack in the pack_metadata.json file and add notes describing your changes to a new Release Notes file. Please feel free to reach out to me with any questions - I'm available here or on slack :) |
Hi @efelmandar, |
@mmhw this really isn't a version update, its a fix. Basically the original version had some incidentfields where the markdown was stripped out and didn't make it in. Im just trying to fix that. do i need to still add a version for that? |
Yes, because not only the README has changed, but also the incidentfields, RN must be added. |
"fromVersion": "6.9.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"fromVersion": "6.9.0" | |
"fromVersion": "6.8.0" |
updated release notes and metadata
Got it @mmhw . If this passes all the checks for this field i got about 6 or 7 fields that needed to be fixed as well. But i wanted to just do a check with this one markdown field to make sure it will work as expected. |
added the release notes, a readme and bumped the version @mmhw |
Hi @joe-cosgrove , |
@@ -0,0 +1,3 @@ | |||
#### Updated Incident Fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#### Updated Incident Fields | |
#### Incident Fields |
Hi @joe-cosgrove, |
Okay @mmhw , i wasnt sure if i needed to put it in the .ignore validations or if this was a actual bug. I guess i lll wait for this to get patched and go from there. |
when is the update @mmhw for the sdk, i really want to finish the updates to my pack |
Hi @joe-cosgrove, |
Closing since i opened a new one with more fixes and documentation |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Fixing the incidentfields and their markdown
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have