Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incidentfields markdown format #27945

Conversation

joe-cosgrove
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fixing the incidentfields and their markdown

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • [ X] 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • [X ] No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! Community Support Level Indicates that the contribution is for Community supported pack labels Jul 5, 2023
@content-bot content-bot changed the base branch from master to contrib/joe-cosgrove_usecasebuilderfixes July 5, 2023 20:29
@content-bot content-bot requested a review from mmhw July 5, 2023 20:29
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed.

@mmhw
Copy link
Contributor

mmhw commented Jul 6, 2023

Hi @joe-cosgrove,
Thank you for your contribution!
Good work :)

Please bump the version of the pack in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run the demisto-sdk update-release-notes -i Packs/Use_Case_Builder command - for more information please see here.

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

@mmhw mmhw requested a review from efelmandar July 6, 2023 09:28
@mmhw
Copy link
Contributor

mmhw commented Jul 6, 2023

Hi @efelmandar,
Can you please take a look here?

@joe-cosgrove
Copy link
Contributor Author

@mmhw this really isn't a version update, its a fix. Basically the original version had some incidentfields where the markdown was stripped out and didn't make it in. Im just trying to fix that. do i need to still add a version for that?

@mmhw
Copy link
Contributor

mmhw commented Jul 6, 2023

this really isn't a version update, its a fix. Basically the original version had some incidentfields where the markdown was stripped out and didn't make it in. Im just trying to fix that. do i need to still add a version for that?

Yes, because not only the README has changed, but also the incidentfields, RN must be added.

"fromVersion": "6.9.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"fromVersion": "6.9.0"
"fromVersion": "6.8.0"

@joe-cosgrove
Copy link
Contributor Author

Got it @mmhw . If this passes all the checks for this field i got about 6 or 7 fields that needed to be fixed as well. But i wanted to just do a check with this one markdown field to make sure it will work as expected.

@joe-cosgrove
Copy link
Contributor Author

added the release notes, a readme and bumped the version @mmhw

@joe-cosgrove
Copy link
Contributor Author

image
This is what the template field does. it sets the data in the markdown field. Not sure why it is giving a error on this field?

@mmhw
Copy link
Contributor

mmhw commented Jul 9, 2023

This is what the template field does. it sets the data in the markdown field. Not sure why it is giving a error on this field?

Hi @joe-cosgrove ,
It seems we have an issue with the incident fields schema, I'm checking it

@@ -0,0 +1,3 @@
#### Updated Incident Fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Updated Incident Fields
#### Incident Fields

@mmhw
Copy link
Contributor

mmhw commented Jul 10, 2023

Hi @joe-cosgrove,
I've added a patch to demisto-sdk here, we'll wait for a new version to be released (scheduled for the beginning of next week), then we'll merge.

@joe-cosgrove
Copy link
Contributor Author

Okay @mmhw , i wasnt sure if i needed to put it in the .ignore validations or if this was a actual bug. I guess i lll wait for this to get patched and go from there.

@joe-cosgrove
Copy link
Contributor Author

when is the update @mmhw for the sdk, i really want to finish the updates to my pack

@mmhw
Copy link
Contributor

mmhw commented Jul 13, 2023

when is the update @mmhw for the sdk, i really want to finish the updates to my pack

Hi @joe-cosgrove,
The release of demisto-sdk is scheduled for this Sunday

@joe-cosgrove
Copy link
Contributor Author

Closing since i opened a new one with more fixes and documentation

#28237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome!
Projects
None yet
3 participants