Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core api file delete: reverting deleting files from context data #27960

Merged
merged 16 commits into from Sep 6, 2023

Conversation

maimorag
Copy link
Contributor

@maimorag maimorag commented Jul 6, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

relates: link to the issue

Description

Fixed a bug in 'core-api-file-delete' where all the files were deleted from context data instead of the selected one.
Also fixed some 'if' errors.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.8.0

Does it break backward compatibility?

  • No

@maimorag maimorag changed the title Core api file delete fix Core api file delete: reverting deleting files from context data Sep 5, 2023
@dorschw dorschw merged commit 56e2cd6 into master Sep 6, 2023
14 of 15 checks passed
@dorschw dorschw deleted the core_api_file_delete_fix branch September 6, 2023 11:53
moishce pushed a commit that referenced this pull request Sep 14, 2023
)

* Fix a bug in core-api-file-delete

* fixed if

* server fix

* server fixes

* server add on

* removing delete context

* removing type chat

* adding RL

* fixing condition

* fixing validation errors

* fixing validation

* guy manor fix after checks

* Update CoreRESTAPI.yml

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
…isto#27960)

* Fix a bug in core-api-file-delete

* fixed if

* server fix

* server fixes

* server add on

* removing delete context

* removing type chat

* adding RL

* fixing condition

* fixing validation errors

* fixing validation

* guy manor fix after checks

* Update CoreRESTAPI.yml

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
)

* Fix a bug in core-api-file-delete

* fixed if

* server fix

* server fixes

* server add on

* removing delete context

* removing type chat

* adding RL

* fixing condition

* fixing validation errors

* fixing validation

* guy manor fix after checks

* Update CoreRESTAPI.yml

---------

Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants