Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - Expander 4135 - IPv4 / IPv6 #27970

Merged

Conversation

BigEasyJ
Copy link
Contributor

@BigEasyJ BigEasyJ commented Jul 6, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

EXPANDR-4135

Description

Updates Cortex ASM - Enrichment playbook conditionals to check if inputs.RemoteIP is an IPv4 address.

Screenshots

Screenshot 2023-06-29 at 3 56 44 PM Screenshot 2023-06-29 at 3 56 26 PM Screenshot 2023-06-29 at 3 56 53 PM

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jul 6, 2023
@content-bot content-bot changed the base branch from master to contrib/BigEasyJ_expander-4135-IPv6 July 6, 2023 23:17
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed.

@content-bot content-bot requested a review from mmhw July 6, 2023 23:18
@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Jul 6, 2023
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BigEasyJ , looks good, approved

@johnnywilkes
Copy link
Contributor

@mmhw , please merge when possible
keep in mind that if merge before #27795, that version might need to be changed

@johnnywilkes johnnywilkes mentioned this pull request Jul 7, 2023
11 tasks
Copy link
Contributor

@mmhw mmhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@mmhw mmhw merged commit e8aa6f0 into demisto:contrib/BigEasyJ_expander-4135-IPv6 Jul 9, 2023
18 of 19 checks passed
mmhw pushed a commit that referenced this pull request Jul 9, 2023
* Add Regex for IPv4 to handle IPv6.

* Add release notes

---------

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Add Regex for IPv4 to handle IPv6.

* Add release notes

---------

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
* Add Regex for IPv4 to handle IPv6.

* Add release notes

---------

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
4 participants