ASM - Expander - Jira Notification #27987

johnnywilkes · 2023-07-07T18:08:48Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

https://jira-hq.paloaltonetworks.local/browse/EXPANDR-3213

Description

Adding Jira for notification purposes. Taking this opportunity to make some parts of the parent playbook as sub-playbooks for organization.

Screenshots

n/a

Minimum version of Cortex XSOAR

6.0.0
6.1.0
6.2.0
6.5.0

Does it break backward compatibility?

Yes
- Further details:
No

Must have

Tests
Documentation

content-bot · 2023-07-07T18:10:56Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @mmhw will know the proposed changes are ready to be reviewed.

johnnywilkes · 2023-07-07T18:34:18Z

@ShirleyDenkberg , can you please review when possible

johnnywilkes · 2023-07-07T18:53:46Z

@capanw / @BigEasyJ , please review when possible. This error will clear, when #27795 goes through:
https://app.circleci.com/pipelines/github/demisto/content/279298/workflows/836d894b-d701-4049-8b2b-75a1baed8e82/jobs/709062

@mmhw , I assume that you will be able to bypass this error? https://github.com/demisto/content/actions/runs/5489464476/jobs/10003653319?pr=27987

mmhw · 2023-07-09T07:48:48Z

Hi @johnnywilkes,
For me it looks good, please update when it is possible to merge it.

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM_Alert.yml

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM_Alert_README.md

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Email_Notification_README.md

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ServiceNow_Notification_README.md

ShirleyDenkberg · 2023-07-09T08:33:30Z

Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_6_23.md

+
+##### New: Cortex ASM - ServiceNow Notification
+
+Added the "Cortex ASM - ServiceNow Notification" Playbook that is used to create ServiceNow tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).


Suggested change

Added the "Cortex ASM - ServiceNow Notification" Playbook that is used to create ServiceNow tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).

Added the "Cortex ASM - ServiceNow Notification" playbook that is used to create ServiceNow tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).

ShirleyDenkberg · 2023-07-09T08:33:49Z

Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_6_23.md

+
+##### Cortex ASM - Remediation Path Rules
+
+Updated the playbook to incorporate Jira check and dynamic data collection task.


Suggested change

Updated the playbook to incorporate Jira check and dynamic data collection task.

Updated the playbook to incorporate a Jira check and a dynamic data collection task.

ShirleyDenkberg · 2023-07-09T08:34:04Z

Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_6_23.md

+
+##### New: Cortex ASM - Jira Notification
+
+Added the "Cortex ASM - Jira Notification" Playbook that is used to create Jira tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).


Suggested change

Added the "Cortex ASM - Jira Notification" Playbook that is used to create Jira tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).

Added the "Cortex ASM - Jira Notification" playbook that is used to create Jira tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).

ShirleyDenkberg · 2023-07-09T08:34:23Z

Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_6_23.md

+
+##### New: Cortex ASM - Email Notification
+
+Added the "Cortex ASM - Email Notification" Playbook that is used to send email notifications to service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).


Suggested change

Added the "Cortex ASM - Email Notification" Playbook that is used to send email notifications to service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).

Added the "Cortex ASM - Email Notification" playbook that is used to send email notifications to service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).

ShirleyDenkberg · 2023-07-09T08:35:20Z

@mmhw Doc review completed.

capanw · 2023-07-09T16:33:23Z

Packs/CortexAttackSurfaceManagement/.pack-ignore

@@ -4,7 +4,7 @@ ignore=IF100
 [file:incidentfield-ASM_-_Playbook_Stage.json]
 ignore=IF100

-[file:Cortex_ASM_-_ASM_Alert.yml]


@johnnywilkes This was intentionally removed?

yes, that effectively disabled a validation error that was in Cortex_ASM_-ASM_Alert.yml and got moved to Cortex_ASM-_ServiceNow_Notification.yml

capanw · 2023-07-09T16:34:37Z

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM_Alert.yml

      methods: []
-      format: html
+      format: ""


HTML format is not needed to be specified anymore?

This GIT diff is really confusing and not sure why it is comparing these two tasks that are totally different. All of the "Select Remediation Action" data collection tasks have been moved to "Cortex ASM - Remediation Path Rules" as a single task and it is using format: html
https://github.com/johnnywilkes/content-jw/blob/14a3c5b116527d9cab0277e50686ab9c06c0a26f/Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Remediation_Path_Rules.yml#L1417

capanw · 2023-07-09T16:37:13Z

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Jira_Notification.yml

+              suffix:
+                iscontext: true
+      val4:
+        simple: TIMESTAMP


Observed this in few other places. Is TIMESTAMP a string? I'm guessing it should get the ISO time format and in the playbook run, I saw that the value is literal TIMESTAMP instead of an actual timestamp.

check out this PR: #26634

capanw · 2023-07-09T16:38:30Z

@johnnywilkes Great work. Added few comments.

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

CLAassistant · 2023-07-11T15:05:27Z

All committers have signed the CLA.

…-3213

johnnywilkes · 2023-07-11T18:17:55Z

@mmhw , this has been approved from our side. Please merge when possible, please.

johnnywilkes · 2023-07-11T21:31:18Z

@mmhw , sorry for the back and forth, our QA found a potential issue I want to look into before we merge

johnnywilkes · 2023-07-13T14:01:30Z

@mmhw , so the UI fix should be in Sunday. So after verified Monday I will take this out of draft stage

…-3213

johnnywilkes · 2023-07-17T18:50:40Z

@mmhw , we are good to merge now, please do when possible

content-bot · 2023-07-18T08:24:11Z

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5797461

mmhw

Good work!

* ASM - Expander - Jira Notification (#27987) * 1st batch * 2nd batch * RN * update README links * RN typo * fix val errors * update rel version and remove NMAP * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * update input * fix Alert validation --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: bigeasyj <janny@paloaltonetworks.com> * Bump the version * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * revert the core packs * set skipunavailable to true in jira-create-issue --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: bigeasyj <janny@paloaltonetworks.com> Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>

* ASM - Expander - Jira Notification (demisto#27987) * 1st batch * 2nd batch * RN * update README links * RN typo * fix val errors * update rel version and remove NMAP * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * update input * fix Alert validation --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: bigeasyj <janny@paloaltonetworks.com> * Bump the version * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * revert the core packs * set skipunavailable to true in jira-create-issue --------- Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: bigeasyj <janny@paloaltonetworks.com> Co-authored-by: Menachem Weinfeld <mmhw770@gmail.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com>

johnnywilkes added 3 commits July 7, 2023 12:52

1st batch

ea078eb

2nd batch

3fa4eee

RN

9434153

content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Jul 7, 2023

johnnywilkes marked this pull request as draft July 7, 2023 18:09

content-bot added Contribution Thank you! Contributions are always welcome! Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jul 7, 2023

content-bot changed the base branch from master to contrib/johnnywilkes_ASM-EXPANDR-3213 July 7, 2023 18:10

content-bot assigned mmhw Jul 7, 2023

content-bot requested a review from mmhw July 7, 2023 18:10

johnnywilkes added 3 commits July 7, 2023 14:14

update README links

72882ff

RN typo

637aa41

fix val errors

32e366b

johnnywilkes marked this pull request as ready for review July 7, 2023 18:30

johnnywilkes marked this pull request as draft July 7, 2023 18:30

ShirleyDenkberg self-assigned this Jul 9, 2023

ShirleyDenkberg reviewed Jul 9, 2023

View reviewed changes

ShirleyDenkberg added the docs-approved label Jul 9, 2023

capanw reviewed Jul 9, 2023

View reviewed changes

johnnywilkes and others added 2 commits July 10, 2023 10:23

update rel version and remove NMAP

14a3c5b

Apply suggestions from code review

56144de

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

johnnywilkes requested review from yucohen, Ni-Knight, ostolero and yaakovpraisler as code owners July 11, 2023 15:05

johnnywilkes force-pushed the ASM-EXPANDR-3213 branch from 116a67c to ba01be3 Compare July 11, 2023 15:17

Merge branch 'master' into ASM-EXPANDR-3213

f888e7b

BigEasyJ force-pushed the ASM-EXPANDR-3213 branch from 8732e19 to f888e7b Compare July 11, 2023 16:56

johnnywilkes and others added 2 commits July 11, 2023 14:02

fix Alert validation

5d8723b

Merge branch 'contrib/johnnywilkes_ASM-EXPANDR-3213' into ASM-EXPANDR…

3fd8700

…-3213

johnnywilkes marked this pull request as draft July 11, 2023 21:25

daryakoval removed their request for review July 12, 2023 07:06

yucohen removed their request for review July 12, 2023 08:10

Ni-Knight removed their request for review July 13, 2023 14:30

johnnywilkes marked this pull request as ready for review July 17, 2023 18:49

Merge branch 'contrib/johnnywilkes_ASM-EXPANDR-3213' into ASM-EXPANDR…

e90daa8

…-3213

mmhw added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 18, 2023

mmhw added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jul 18, 2023

mmhw approved these changes Jul 18, 2023

View reviewed changes

mmhw merged commit 04836a1 into demisto:contrib/johnnywilkes_ASM-EXPANDR-3213 Jul 18, 2023
16 of 18 checks passed

content-bot mentioned this pull request Jul 18, 2023

ASM - Expander - Jira Notification #28259

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ASM - Expander - Jira Notification #27987

ASM - Expander - Jira Notification #27987

johnnywilkes commented Jul 7, 2023

content-bot commented Jul 7, 2023

johnnywilkes commented Jul 7, 2023

johnnywilkes commented Jul 7, 2023

mmhw commented Jul 9, 2023

ShirleyDenkberg Jul 9, 2023

ShirleyDenkberg Jul 9, 2023

ShirleyDenkberg Jul 9, 2023

ShirleyDenkberg Jul 9, 2023

ShirleyDenkberg commented Jul 9, 2023

capanw Jul 9, 2023

johnnywilkes Jul 10, 2023

capanw Jul 9, 2023

johnnywilkes Jul 10, 2023

capanw Jul 9, 2023

johnnywilkes Jul 10, 2023

capanw commented Jul 9, 2023

CLAassistant commented Jul 11, 2023 •

edited

johnnywilkes commented Jul 11, 2023

johnnywilkes commented Jul 11, 2023

johnnywilkes commented Jul 13, 2023

johnnywilkes commented Jul 17, 2023

content-bot commented Jul 18, 2023 •

edited

mmhw left a comment


		##### New: Cortex ASM - ServiceNow Notification

		Added the "Cortex ASM - ServiceNow Notification" Playbook that is used to create ServiceNow tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).


		##### Cortex ASM - Remediation Path Rules

		Updated the playbook to incorporate Jira check and dynamic data collection task.

	Updated the playbook to incorporate Jira check and dynamic data collection task.
	Updated the playbook to incorporate a Jira check and a dynamic data collection task.


		##### New: Cortex ASM - Jira Notification

		Added the "Cortex ASM - Jira Notification" Playbook that is used to create Jira tickets directed toward service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).


		##### New: Cortex ASM - Email Notification

		Added the "Cortex ASM - Email Notification" Playbook that is used to send email notifications to service owners to notify them of their internet exposures. (Available from Cortex XSOAR 6.8.0).

ASM - Expander - Jira Notification #27987

ASM - Expander - Jira Notification #27987

Conversation

johnnywilkes commented Jul 7, 2023

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Screenshots

Minimum version of Cortex XSOAR

Does it break backward compatibility?

Must have

content-bot commented Jul 7, 2023

johnnywilkes commented Jul 7, 2023

johnnywilkes commented Jul 7, 2023

mmhw commented Jul 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShirleyDenkberg commented Jul 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

capanw commented Jul 9, 2023

CLAassistant commented Jul 11, 2023 • edited

johnnywilkes commented Jul 11, 2023

johnnywilkes commented Jul 11, 2023

johnnywilkes commented Jul 13, 2023

johnnywilkes commented Jul 17, 2023

content-bot commented Jul 18, 2023 • edited

mmhw left a comment

Choose a reason for hiding this comment

CLAassistant commented Jul 11, 2023 •

edited

content-bot commented Jul 18, 2023 •

edited